From 31779e0772006d822bb35b3f3fe0f0623d021aff Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Sat, 25 Apr 2015 08:06:14 +0200
Subject: compilation_SUITE: Speed up the self_compile test cases

It is not necessary to compile the compile three times. After the
second compilation, we compare the generated .beam files with the
.beam files that were used when compiling them. Doing one more
round will not find more bugs.

While we are it, remove the ?line macros and the unused make_current/1
function.
---
 lib/compiler/test/compilation_SUITE.erl | 55 +++++++++++++--------------------
 1 file changed, 22 insertions(+), 33 deletions(-)

(limited to 'lib/compiler/test/compilation_SUITE.erl')

diff --git a/lib/compiler/test/compilation_SUITE.erl b/lib/compiler/test/compilation_SUITE.erl
index 51e1da2cb6..f570d94f7d 100644
--- a/lib/compiler/test/compilation_SUITE.erl
+++ b/lib/compiler/test/compilation_SUITE.erl
@@ -428,41 +428,35 @@ self_compile_old_inliner(Config) when is_list(Config) ->
     self_compile_1(Config, "old", [verbose,{inline,500}]).
 
 self_compile_1(Config, Prefix, Opts) ->
-    ?line Dog = test_server:timetrap(test_server:minutes(40)),
+    Dog = test_server:timetrap(test_server:minutes(40)),
 
-    ?line Priv = ?config(priv_dir,Config),
-    ?line Version = compiler_version(),
+    Priv = ?config(priv_dir,Config),
+    Version = compiler_version(),
 
     %% Compile the compiler. (In this node to get better coverage.)
-    ?line CompA = make_compiler_dir(Priv, Prefix++"compiler_a"),
-    ?line VsnA = Version ++ ".0",
+    CompA = make_compiler_dir(Priv, Prefix++"compiler_a"),
+    VsnA = Version ++ ".0",
     compile_compiler(compiler_src(), CompA, VsnA, [clint0,clint|Opts]),
 
     %% Compile the compiler again using the newly compiled compiler.
     %% (In another node because reloading the compiler would disturb cover.)
     CompilerB = Prefix++"compiler_b",
     CompB = make_compiler_dir(Priv, CompilerB),
-    ?line VsnB = VsnA ++ ".0",
+    VsnB = VsnA ++ ".0",
     self_compile_node(CompA, CompB, VsnB, Opts),
 
-    %% Compare compiler directories.
-    ?line compare_compilers(CompA, CompB),
+    %% Compare compiler directories. The compiler directories should
+    %% be equal (except for beam_asm that contains the compiler version).
+    compare_compilers(CompA, CompB),
 
-    %% Compile and compare compiler C.
-    ?line CompilerC = Prefix++"compiler_c",
-    ?line CompC = make_compiler_dir(Priv, CompilerC),
-    ?line VsnC = VsnB ++ ".0",
-    self_compile_node(CompB, CompC, VsnC, Opts),
-    ?line compare_compilers(CompB, CompC),
-
-    ?line test_server:timetrap_cancel(Dog),
+    test_server:timetrap_cancel(Dog),
     ok.
 
 self_compile_node(CompilerDir, OutDir, Version, Opts) ->
-    ?line Dog = test_server:timetrap(test_server:minutes(15)),
-    ?line Pa = "-pa " ++ filename:dirname(code:which(?MODULE)) ++
+    Dog = test_server:timetrap(test_server:minutes(15)),
+    Pa = "-pa " ++ filename:dirname(code:which(?MODULE)) ++
 	" -pa " ++ CompilerDir,
-    ?line Files = compiler_src(),
+    Files = compiler_src(),
 
     %% We don't want the cover server started on the other node,
     %% because it will load the same cover-compiled code as on this
@@ -472,7 +466,7 @@ self_compile_node(CompilerDir, OutDir, Version, Opts) ->
        fun() ->
 	       compile_compiler(Files, OutDir, Version, Opts)
        end, Pa),
-    ?line test_server:timetrap_cancel(Dog),
+    test_server:timetrap_cancel(Dog),
     ok.
 
 compile_compiler(Files, OutDir, Version, InlineOpts) ->
@@ -499,27 +493,22 @@ compiler_modules(Dir) ->
     [list_to_atom(filename:rootname(filename:basename(F))) || F <- Files].
 
 make_compiler_dir(Priv, Dir0) ->
-    ?line Dir = filename:join(Priv, Dir0),
-    ?line ok = file:make_dir(Dir),
+    Dir = filename:join(Priv, Dir0),
+    ok = file:make_dir(Dir),
     Dir.
 
-make_current(Dir) ->    
-    true = code:add_patha(Dir),
-    lists:foreach(fun(File) ->
-			  c:l(File)
-		  end, compiler_modules(Dir)),
-    io:format("~p\n", [code:which(compile)]).
-
 compiler_version() ->
-    {value,{version,Version}} = lists:keysearch(version, 1,
-						compile:module_info(compile)),
+    {version,Version} = lists:keyfind(version, 1,
+				      compile:module_info(compile)),
     Version.
 
 compare_compilers(ADir, BDir) ->
     {[],[],D} = beam_lib:cmp_dirs(ADir, BDir),
-    [] = [T || {A,_}=T <- D,
-	       filename:basename(A) =/= "beam_asm.beam"]. %Contains compiler version.
 
+    %% beam_asm.beam contains compiler version and therefore it *must*
+    %% compare unequal.
+    ["beam_asm.beam"] = [filename:basename(A) || {A,_} <- D],
+    ok.
 
 %%%
 %%% The only test of the following code is that it compiles.
-- 
cgit v1.2.3