From 347dfb022195994a368ff12f8d009b7263044f50 Mon Sep 17 00:00:00 2001
From: Haitao Li <lihaitao@gmail.com>
Date: Fri, 22 Jul 2011 17:14:30 +0800
Subject: beam_disasm: Handle stripped BEAM files

beam_disasm:file/1 would crash if asked to disassemble a stripped
BEAM file without an "Attr" chunk.
---
 lib/compiler/src/beam_disasm.erl        |  2 +-
 lib/compiler/test/Makefile              |  1 +
 lib/compiler/test/beam_disasm_SUITE.erl | 65 +++++++++++++++++++++++++++++++++
 3 files changed, 67 insertions(+), 1 deletion(-)
 create mode 100644 lib/compiler/test/beam_disasm_SUITE.erl

(limited to 'lib/compiler')

diff --git a/lib/compiler/src/beam_disasm.erl b/lib/compiler/src/beam_disasm.erl
index 017ca129b0..bb62bb04b3 100644
--- a/lib/compiler/src/beam_disasm.erl
+++ b/lib/compiler/src/beam_disasm.erl
@@ -204,7 +204,7 @@ process_chunks(F) ->
 optional_chunk(F, ChunkTag) ->
     case beam_lib:chunks(F, [ChunkTag]) of
 	{ok,{_Module,[{ChunkTag,Chunk}]}} -> Chunk;
-	{error,beam_lib,{missing_chunk,_,ChunkTag}} -> none
+	{error,beam_lib,{missing_chunk,_,_}} -> none
     end.
 
 %%-----------------------------------------------------------------------
diff --git a/lib/compiler/test/Makefile b/lib/compiler/test/Makefile
index fe713fd019..b90adaf917 100644
--- a/lib/compiler/test/Makefile
+++ b/lib/compiler/test/Makefile
@@ -9,6 +9,7 @@ MODULES= \
 	andor_SUITE \
 	apply_SUITE \
 	beam_validator_SUITE \
+	beam_disasm_SUITE \
 	bs_bincomp_SUITE \
 	bs_bit_binaries_SUITE \
 	bs_construct_SUITE \
diff --git a/lib/compiler/test/beam_disasm_SUITE.erl b/lib/compiler/test/beam_disasm_SUITE.erl
new file mode 100644
index 0000000000..44574ae64a
--- /dev/null
+++ b/lib/compiler/test/beam_disasm_SUITE.erl
@@ -0,0 +1,65 @@
+%%
+%% %CopyrightBegin%
+%%
+%% Copyright Ericsson AB 2011. All Rights Reserved.
+%%
+%% The contents of this file are subject to the Erlang Public License,
+%% Version 1.1, (the "License"); you may not use this file except in
+%% compliance with the License. You should have received a copy of the
+%% Erlang Public License along with this software. If not, it can be
+%% retrieved online at http://www.erlang.org/.
+%%
+%% Software distributed under the License is distributed on an "AS IS"
+%% basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
+%% the License for the specific language governing rights and limitations
+%% under the License.
+%%
+%% %CopyrightEnd%
+%%
+-module(beam_disasm_SUITE).
+
+-include_lib("test_server/include/test_server.hrl").
+
+-export([all/0, suite/0,groups/0,init_per_suite/1, end_per_suite/1,
+	 init_per_group/2,end_per_group/2]).
+
+-export([stripped/1]).
+
+suite() -> [{ct_hooks,[ts_install_cth]}].
+
+all() ->
+    [stripped].
+
+groups() ->
+    [].
+
+init_per_suite(Config) ->
+    Config.
+
+end_per_suite(_Config) ->
+    ok.
+
+init_per_group(_GroupName, Config) ->
+    Config.
+
+end_per_group(_GroupName, Config) ->
+    Config.
+
+stripped(doc) ->
+    ["Check that stripped beam files can be disassembled"];
+stripped(Config) when is_list(Config) ->
+    ?line PrivDir = ?config(priv_dir, Config),
+    ?line SrcName = filename:join(PrivDir, "tmp.erl"),
+    ?line BeamName = filename:join(PrivDir, "tmp.beam"),
+    Prog = <<"-module(tmp).\n-export([tmp/0]).\ntmp()->ok.\n">>,
+    ?line ok = file:write_file(SrcName, Prog),
+    ?line {ok, tmp} =
+	compile:file(SrcName, [{outdir, PrivDir}]),
+    ?line {beam_file, tmp, _, Attr, CompileInfo, [_|_]} =
+	beam_disasm:file(BeamName),
+    ?line true = is_list(Attr),
+    ?line true = is_list(CompileInfo),
+    ?line {ok, {tmp, _}} = beam_lib:strip(BeamName),
+    ?line {beam_file, tmp, _, none, none, [_|_]} =
+	beam_disasm:file(BeamName),
+    ok.
-- 
cgit v1.2.3