From 3ce276a09e93493dce296737e3e86147381d4d96 Mon Sep 17 00:00:00 2001 From: Kostis Sagonas Date: Fri, 24 Aug 2012 14:09:11 +0200 Subject: Changes to fix warnings identified by running dialyzer -Wunmatched_returns --- lib/dialyzer/src/dialyzer_analysis_callgraph.erl | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'lib/dialyzer/src/dialyzer_analysis_callgraph.erl') diff --git a/lib/dialyzer/src/dialyzer_analysis_callgraph.erl b/lib/dialyzer/src/dialyzer_analysis_callgraph.erl index 496d317f8a..f42ce85b83 100644 --- a/lib/dialyzer/src/dialyzer_analysis_callgraph.erl +++ b/lib/dialyzer/src/dialyzer_analysis_callgraph.erl @@ -519,9 +519,10 @@ rcv_and_send_ext_types(Parent) -> Self ! {Self, done}, case rcv_ext_types(Self, []) of [] -> ok; - ExtTypes -> Parent ! {Self, ext_types, ExtTypes} - end, - ok. + ExtTypes -> + Parent ! {Self, ext_types, ExtTypes}, + ok + end. rcv_ext_types(Self, ExtTypes) -> receive -- cgit v1.2.3 From ab32117d6edeaaf36d8842a74848a338c1bc8f14 Mon Sep 17 00:00:00 2001 From: Kostis Sagonas Date: Fri, 24 Aug 2012 17:03:31 +0200 Subject: Stop a forgotten server process Dialyzer forgot to stop a server process before finishing its analysis. This is a concurrency error detected by Concuerror. --- lib/dialyzer/src/dialyzer_analysis_callgraph.erl | 1 + 1 file changed, 1 insertion(+) (limited to 'lib/dialyzer/src/dialyzer_analysis_callgraph.erl') diff --git a/lib/dialyzer/src/dialyzer_analysis_callgraph.erl b/lib/dialyzer/src/dialyzer_analysis_callgraph.erl index f42ce85b83..c237d4e0e9 100644 --- a/lib/dialyzer/src/dialyzer_analysis_callgraph.erl +++ b/lib/dialyzer/src/dialyzer_analysis_callgraph.erl @@ -184,6 +184,7 @@ analysis_start(Parent, Analysis) -> false -> Callgraph end, State3 = analyze_callgraph(NewCallgraph, State2#analysis_state{plt = Plt1}), + dialyzer_callgraph:dispose_race_server(NewCallgraph), rcv_and_send_ext_types(Parent), NonExports = sets:subtract(sets:from_list(AllNodes), Exports), NonExportsList = sets:to_list(NonExports), -- cgit v1.2.3