From 29253c06dd99717e8424c0418144fd95d232c38d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Magnus=20L=C3=A5ng?= Date: Tue, 19 Apr 2016 15:02:17 +0200 Subject: erl_types: Fix t_subtract/2 correctness bug t_subtract/2 would break its postcondition by always returning the underapproximation none() when given a variable on the right hand side. This broke map type parsing, since it relied on t_subtract/2 to tell it when map keys would shadow each other. --- .../test/map_SUITE_data/src/opaque_key/opaque_key_adt.erl | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'lib/dialyzer/test/map_SUITE_data/src') diff --git a/lib/dialyzer/test/map_SUITE_data/src/opaque_key/opaque_key_adt.erl b/lib/dialyzer/test/map_SUITE_data/src/opaque_key/opaque_key_adt.erl index 53ec09b062..b98c713c6b 100644 --- a/lib/dialyzer/test/map_SUITE_data/src/opaque_key/opaque_key_adt.erl +++ b/lib/dialyzer/test/map_SUITE_data/src/opaque_key/opaque_key_adt.erl @@ -29,20 +29,20 @@ mt0() -> #{#{} => 3}. -spec s0() -> s(atom()). s0() -> #{}. --spec s1() -> s(atom()). %% No contract breakage (bad warning) +-spec s1() -> s(atom()). s1() -> #{3 => a}. -spec s2() -> s(atom() | 3). -s2() -> #{3 => a}. %% Contract breakage +s2() -> #{3 => a}. %% Contract breakage (not found) -spec s3() -> s(atom() | 3). s3() -> #{3 => 5, a => 6, 7 => 8}. -spec s4() -> s(integer()). -s4() -> #{1 => a}. %% Actual contract breakage (good warning) +s4() -> #{1 => a}. %% Contract breakage -spec s5() -> s(1). -s5() -> #{2 => 3}. %% Contract breakage (not found) +s5() -> #{2 => 3}. %% Contract breakage -spec s6() -> s(1). s6() -> #{1 => 3}. @@ -50,7 +50,7 @@ s6() -> #{1 => 3}. -spec s7() -> s(integer()). s7() -> #{1 => 3}. --spec sm1() -> sm(1). %% No contract breakage (bad warning) +-spec sm1() -> sm(1). sm1() -> #{1 => 2, 3 => a}. -spec smt1() -> smt(1). -- cgit v1.2.3