From 25afc3095657009724b4f690c0d6666b49acfb84 Mon Sep 17 00:00:00 2001
From: Maria Christakis <christakismaria@gmail.com>
Date: Thu, 14 Oct 2010 13:41:22 +0300
Subject: dialyzer: Fix so warnings will be emitted for all public ETS tables

---
 lib/dialyzer/src/dialyzer_races.erl | 38 +++++++------------------------------
 1 file changed, 7 insertions(+), 31 deletions(-)

(limited to 'lib/dialyzer')

diff --git a/lib/dialyzer/src/dialyzer_races.erl b/lib/dialyzer/src/dialyzer_races.erl
index ec8d613b96..ee9d5e88a3 100644
--- a/lib/dialyzer/src/dialyzer_races.erl
+++ b/lib/dialyzer/src/dialyzer_races.erl
@@ -118,7 +118,7 @@
                      var_map    :: dict()}).
 
 -type case_tags()  :: 'beg_case' | #beg_clause{} | #end_clause{} | #end_case{}.
--type code()       :: [#dep_call{} | #warn_call{} | #fun_call{} |
+-type code()       :: [#dep_call{} | #fun_call{} | #warn_call{} |
                        #curr_fun{} | #let_tag{} | case_tags() | race_tag()].
 
 -type table_var()  :: label() | ?no_label.
@@ -479,23 +479,11 @@ fixup_race_forward(CurrFun, CurrFunLabel, Calls, Code, RaceList,
               _Other ->
                 {RaceList, [], NestingLevel, false}
             end;
-          #dep_call{call_name = ets_lookup, args = DepCallArgs} ->
+          #dep_call{call_name = ets_lookup} ->
             case RaceWarnTag of
               ?WARN_ETS_LOOKUP_INSERT ->
-                [Tab, Names, _, _] = DepCallArgs,
-                case compare_var_list(Tab,
-                  dialyzer_callgraph:get_public_tables(Callgraph),
-                  RaceVarMap)
-                  orelse
-                  length(Names --
-                  dialyzer_callgraph:get_named_tables(Callgraph)) <
-                  length(Names) of
-                  true ->
-                    {[Head#dep_call{var_map = RaceVarMap}|RaceList],
-                     [], NestingLevel, false};
-                  false ->
-                    {RaceList, [], NestingLevel, false}
-                end;
+                {[Head#dep_call{var_map = RaceVarMap}|RaceList],
+                 [], NestingLevel, false};
               _Other ->
                 {RaceList, [], NestingLevel, false}
             end;
@@ -517,23 +505,11 @@ fixup_race_forward(CurrFun, CurrFunLabel, Calls, Code, RaceList,
               _Other ->
                 {RaceList, [], NestingLevel, false}
             end;
-  	  #warn_call{call_name = ets_insert, args = WarnCallArgs} ->
+  	  #warn_call{call_name = ets_insert} ->
             case RaceWarnTag of
               ?WARN_ETS_LOOKUP_INSERT ->
-                [Tab, Names, _, _] = WarnCallArgs,
-                case compare_var_list(Tab,
-                  dialyzer_callgraph:get_public_tables(Callgraph),
-                  RaceVarMap)
-                  orelse
-                  length(Names --
-                  dialyzer_callgraph:get_named_tables(Callgraph)) <
-                  length(Names) of
-                  true ->
-                    {[Head#warn_call{var_map = RaceVarMap}|RaceList],
-                     [], NestingLevel, false};
-                  false ->
-                    {RaceList, [], NestingLevel, false}
-                end;
+                {[Head#warn_call{var_map = RaceVarMap}|RaceList],
+                 [], NestingLevel, false};
               _Other ->
                 {RaceList, [], NestingLevel, false}
             end;
-- 
cgit v1.2.3