From 3382224b67fe4f1aa8018a97cd159ad5089ba555 Mon Sep 17 00:00:00 2001
From: Hans Bolinder <hasse@erlang.org>
Date: Thu, 2 Apr 2015 16:13:19 +0200
Subject: dialyzer: Move a testcase to plt_SUITE

---
 lib/dialyzer/test/dialyzer_SUITE.erl | 41 +++---------------------------------
 lib/dialyzer/test/plt_SUITE.erl      | 30 ++++++++++++++++++++++++--
 2 files changed, 31 insertions(+), 40 deletions(-)

(limited to 'lib/dialyzer')

diff --git a/lib/dialyzer/test/dialyzer_SUITE.erl b/lib/dialyzer/test/dialyzer_SUITE.erl
index 8507525597..f625d12b45 100644
--- a/lib/dialyzer/test/dialyzer_SUITE.erl
+++ b/lib/dialyzer/test/dialyzer_SUITE.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 2014. All Rights Reserved.
+%% Copyright Ericsson AB 2015. All Rights Reserved.
 %%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -30,12 +30,12 @@
 -export([init_per_testcase/2, end_per_testcase/2]).
 
 %% Test cases must be exported.
--export([app_test/1, appup_test/1, beam_tests/1]).
+-export([app_test/1, appup_test/1]).
 
 suite() -> [{ct_hooks,[ts_install_cth]}].
 
 all() ->
-    [app_test, appup_test, beam_tests].
+    [app_test, appup_test].
 
 groups() ->
     [].
@@ -75,38 +75,3 @@ app_test(Config) when is_list(Config) ->
 %% Test that the .appup file does not contain any `basic' errors
 appup_test(Config) when is_list(Config) ->
     ok = ?t:appup_test(dialyzer).
-
-beam_tests(Config) when is_list(Config) ->
-    Prog = <<"
-              -module(no_auto_import).
-
-              %% Copied from erl_lint_SUITE.erl, clash6
-
-              -export([size/1]).
-
-              size([]) ->
-                  0;
-              size({N,_}) ->
-                  N;
-              size([_|T]) ->
-                  1+size(T).
-             ">>,
-    Opts = [no_auto_import],
-    {ok, BeamFile} = compile(Config, Prog, no_auto_import, Opts),
-    [] = run_dialyzer([BeamFile]),
-    ok.
-
-compile(Config, Prog, Module, CompileOpts) ->
-    Source = lists:concat([Module, ".erl"]),
-    PrivDir = ?config(priv_dir,Config),
-    Filename = filename:join([PrivDir, Source]),
-    ok = file:write_file(Filename, Prog),
-    Opts = [{outdir, PrivDir}, debug_info | CompileOpts],
-    {ok, Module} = compile:file(Filename, Opts),
-    {ok, filename:join([PrivDir, lists:concat([Module, ".beam"])])}.
-
-run_dialyzer(Files) ->
-    dialyzer:run([{analysis_type, plt_build},
-                  {files, Files},
-                  {from, byte_code},
-                  {check_plt, false}]).
diff --git a/lib/dialyzer/test/plt_SUITE.erl b/lib/dialyzer/test/plt_SUITE.erl
index 0b8c6dec21..ef4cdc57f0 100644
--- a/lib/dialyzer/test/plt_SUITE.erl
+++ b/lib/dialyzer/test/plt_SUITE.erl
@@ -6,12 +6,12 @@
 -include_lib("common_test/include/ct.hrl").
 -include("dialyzer_test_constants.hrl").
 
--export([suite/0, all/0, build_plt/1, update_plt/1]).
+-export([suite/0, all/0, build_plt/1, beam_tests/1, update_plt/1]).
 
 suite() ->
   [{timetrap, ?plt_timeout}].
 
-all() -> [build_plt, update_plt].
+all() -> [build_plt, beam_tests, update_plt].
 
 build_plt(Config) ->
   OutDir = ?config(priv_dir, Config),
@@ -20,6 +20,32 @@ build_plt(Config) ->
     fail -> ct:fail(plt_build_fail)
   end.
 
+beam_tests(Config) when is_list(Config) ->
+    Prog = <<"
+              -module(no_auto_import).
+
+              %% Copied from erl_lint_SUITE.erl, clash6
+
+              -export([size/1]).
+
+              size([]) ->
+                  0;
+              size({N,_}) ->
+                  N;
+              size([_|T]) ->
+                  1+size(T).
+             ">>,
+    Opts = [no_auto_import],
+    {ok, BeamFile} = compile(Config, Prog, no_auto_import, Opts),
+    [] = run_dialyzer([BeamFile]),
+    ok.
+
+run_dialyzer(Files) ->
+    dialyzer:run([{analysis_type, plt_build},
+                  {files, Files},
+                  {from, byte_code},
+                  {check_plt, false}]).
+
 %%% [James Fish:]
 %%% If a function is removed from a module and the module has previously
 %%% been added to a PLT, the function will not be removed from PLT when
-- 
cgit v1.2.3