From a360c3e6cdcc54fe040a1aef157eb1489ab4bdb3 Mon Sep 17 00:00:00 2001 From: Stavros Aronis Date: Fri, 21 Mar 2014 17:06:24 +0100 Subject: Don't 'opaque-decorate' a success typing using an incompatible spec Without this patch Dialyzer crashes when analyzing the supplemented test case. --- lib/dialyzer/test/small_SUITE_data/results/invalid_spec_2 | 2 ++ .../test/small_SUITE_data/src/invalid_spec_2/scala_data.erl | 5 +++++ .../test/small_SUITE_data/src/invalid_spec_2/scala_user.erl | 8 ++++++++ 3 files changed, 15 insertions(+) create mode 100644 lib/dialyzer/test/small_SUITE_data/results/invalid_spec_2 create mode 100644 lib/dialyzer/test/small_SUITE_data/src/invalid_spec_2/scala_data.erl create mode 100644 lib/dialyzer/test/small_SUITE_data/src/invalid_spec_2/scala_user.erl (limited to 'lib/dialyzer') diff --git a/lib/dialyzer/test/small_SUITE_data/results/invalid_spec_2 b/lib/dialyzer/test/small_SUITE_data/results/invalid_spec_2 new file mode 100644 index 0000000000..4565112ea0 --- /dev/null +++ b/lib/dialyzer/test/small_SUITE_data/results/invalid_spec_2 @@ -0,0 +1,2 @@ + +scala_user.erl:5: Invalid type specification for function scala_user:is_list/2. The success typing is (maybe_improper_list() | tuple(),_) -> boolean() diff --git a/lib/dialyzer/test/small_SUITE_data/src/invalid_spec_2/scala_data.erl b/lib/dialyzer/test/small_SUITE_data/src/invalid_spec_2/scala_data.erl new file mode 100644 index 0000000000..c26787fe24 --- /dev/null +++ b/lib/dialyzer/test/small_SUITE_data/src/invalid_spec_2/scala_data.erl @@ -0,0 +1,5 @@ +-module(scala_data). + +-export_type([data/0]). + +-opaque data() :: {'data', term()}. diff --git a/lib/dialyzer/test/small_SUITE_data/src/invalid_spec_2/scala_user.erl b/lib/dialyzer/test/small_SUITE_data/src/invalid_spec_2/scala_user.erl new file mode 100644 index 0000000000..4e981f3b74 --- /dev/null +++ b/lib/dialyzer/test/small_SUITE_data/src/invalid_spec_2/scala_user.erl @@ -0,0 +1,8 @@ +-module(scala_user). + +-export([is_list/2]). + +-spec is_list(atom(), scala_data:data()) -> boolean(). + +is_list( List,Data) when is_list(List) -> true; +is_list(Tuple,Data) when is_tuple(Tuple) -> false. -- cgit v1.2.3