From 7aec6ad7e56a377bf84fe833dfde43f52263224a Mon Sep 17 00:00:00 2001 From: Anders Svensson Date: Sat, 22 Apr 2017 23:57:48 +0200 Subject: Use avp_arity/1 when creating a zero group Converting with list_to_binary/1 appears to be faster than the equivalent binary comprehension: << (z(F,A)) || {F,A} <- avp_arity(Name) >> --- lib/diameter/include/diameter_gen.hrl | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'lib/diameter/include') diff --git a/lib/diameter/include/diameter_gen.hrl b/lib/diameter/include/diameter_gen.hrl index 3c59370e73..f788264647 100644 --- a/lib/diameter/include/diameter_gen.hrl +++ b/lib/diameter/include/diameter_gen.hrl @@ -733,10 +733,7 @@ grouped_decode(Name, ComponentAvps) -> %% --------------------------------------------------------------------------- empty_group(Name) -> - list_to_binary(empty_body(Name)). - -empty_body(Name) -> - [z(F, avp_arity(Name, F)) || F <- '#info-'(name2rec(Name), fields)]. + list_to_binary([z(F,A) || {F,A} <- avp_arity(Name)]). z(Name, 1) -> z(Name); -- cgit v1.2.3