From f1a78f768414e97d30e72b1530475f2893fc75c5 Mon Sep 17 00:00:00 2001
From: Anders Svensson <anders@erlang.org>
Date: Mon, 17 Apr 2017 10:51:56 +0200
Subject: Don't create intermediate binaries unnecessarily during encode

Dict:avp(encode, Value, Name) no longer needs to return a binary, only
an iolist(). Message encode runs list_to_binary/1 to convert accumulated
lists into a message binary.
---
 lib/diameter/include/diameter_gen.hrl | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

(limited to 'lib/diameter/include')

diff --git a/lib/diameter/include/diameter_gen.hrl b/lib/diameter/include/diameter_gen.hrl
index e745e3d2d3..e35d448754 100644
--- a/lib/diameter/include/diameter_gen.hrl
+++ b/lib/diameter/include/diameter_gen.hrl
@@ -75,7 +75,7 @@ eraser(K) ->
 %% ---------------------------------------------------------------------------
 
 -spec encode_avps(parent_name(), parent_record() | avp_values())
-   -> binary()
+   -> iolist()
     | no_return().
 
 encode_avps(Name, Vals)
@@ -84,7 +84,7 @@ encode_avps(Name, Vals)
 
 encode_avps(Name, Rec) ->
     try
-        list_to_binary(encode(Name, Rec))
+        encode(Name, Rec)
     catch
         throw: {?MODULE, Reason} ->
             diameter_lib:log({encode, error},
@@ -655,7 +655,7 @@ value(_, Avp) ->
 -spec grouped_avp(decode, avp_name(), bitstring())
    -> {avp_record(), [avp()]};
                  (encode, avp_name(), avp_record() | avp_values())
-   -> binary()
+   -> iolist()
     | no_return().
 
 %% Length error induced by diameter_codec:collect_avps/1: the AVP
@@ -719,10 +719,10 @@ z(Name, {Min, _}) ->
     binary:copy(z(Name), Min).
 
 z('AVP') ->
-    <<0:64/integer>>;  %% minimal header
+    <<0:64>>;  %% minimal header
 z(Name) ->
     Bin = diameter_codec:pack_avp(avp_header(Name), empty_value(Name)),
-    Sz = size(Bin),
+    Sz = iolist_size(Bin),
     <<0:Sz/unit:8>>.
 
 %% ---------------------------------------------------------------------------
-- 
cgit v1.2.3