From 1da8a27f08a890d3ba44ad9707b848ff8afbc1f5 Mon Sep 17 00:00:00 2001
From: Anders Svensson <anders@erlang.org>
Date: Sat, 16 Feb 2013 01:14:12 +0100
Subject: Answer 5xxx errors with application_opt() request_errors = answer

RFC 3588 allowed only 3xxx result codes in an answer-message (that is,
an answer that sets the E-bit) while RFC 6733 also allows 5xxx result
codes. Setting request_errors = answer tells diameter to answer 5xxx
errors itself. Returning {answer_message, integer()} from a
handle_request callback allows both 3xxx and 5xxx result codes to be
set. {protocol_error, integer()} is retained for 3xxx result codes.
---
 lib/diameter/src/base/diameter_config.erl | 43 ++++++++++++-------------------
 1 file changed, 16 insertions(+), 27 deletions(-)

(limited to 'lib/diameter/src/base/diameter_config.erl')

diff --git a/lib/diameter/src/base/diameter_config.erl b/lib/diameter/src/base/diameter_config.erl
index 889c75e3da..9f73815756 100644
--- a/lib/diameter/src/base/diameter_config.erl
+++ b/lib/diameter/src/base/diameter_config.erl
@@ -670,17 +670,17 @@ app_acc({application, Opts}, Acc) ->
     [Dict, Mod] = get_opt([dictionary, module], Opts),
     Alias = get_opt(alias, Opts, Dict),
     ModS  = get_opt(state, Opts, Alias),
-    M = get_opt(call_mutates_state, Opts, false),
-    A = get_opt(answer_errors, Opts, report),
-    R = get_opt(request_errors, Opts, answer_3xxx),
+    M = get_opt(call_mutates_state, Opts, false, [true]),
+    A = get_opt(answer_errors, Opts, report, [callback, discard]),
+    P = get_opt(request_errors, Opts, answer_3xxx, [answer, callback]),
     [#diameter_app{alias = Alias,
                    dictionary = Dict,
                    id = cb(Dict, id),
                    module = init_mod(Mod),
                    init_state = ModS,
-                   mutable = init_mutable(M),
-                   options = [{answer_errors, init_answers(A)},
-                              {request_errors, init_request_errors(R)}]}
+                   mutable = M,
+                   options = [{answer_errors, A},
+                              {request_errors, P}]}
      | Acc];
 app_acc(_, Acc) ->
     Acc.
@@ -709,27 +709,16 @@ init_cb(List) ->
                    V <- [proplists:get_value(F, List, D)]],
     #diameter_callback{} = list_to_tuple([diameter_callback | Values]).
 
-init_mutable(M)
-  when M == true;
-       M == false ->
-    M;
-init_mutable(M) ->
-    ?THROW({call_mutates_state, M}).
-
-init_answers(A)
-  when callback == A;
-       report == A;
-       discard == A ->
-    A;
-init_answers(A) ->
-    ?THROW({answer_errors, A}).
-
-init_request_errors(P)
-  when callback == P;
-       answer_3xxx == P ->
-    P;
-init_request_errors(P) ->
-    ?THROW({request_errors, P}).
+%% Retreive and validate.
+get_opt(Key, List, Def, Other) ->
+    init_opt(Key, get_opt(Key, List, Def), [Def|Other]).
+
+init_opt(_, V, [V|_]) ->
+    V;
+init_opt(Name, V, [_|Vals]) ->
+    init_opt(Name, V, Vals);
+init_opt(Name, V, []) ->
+    ?THROW({Name, V}).
 
 %% Get a single value at the specified key.
 get_opt(Keys, List)
-- 
cgit v1.2.3