From 265c88664b93f9069c86bf6c25e5d07b7f41d2dc Mon Sep 17 00:00:00 2001
From: Anders Svensson <anders@erlang.org>
Date: Mon, 23 Sep 2013 10:31:21 +0200
Subject: Extend diameter_make:codec/2

Function can now take a literal dictionary as input, instead of a path,
and can return results instead of writing them to the filesystem.
---
 lib/diameter/src/compiler/diameter_codegen.erl | 79 ++++++++++++++++----------
 1 file changed, 48 insertions(+), 31 deletions(-)

(limited to 'lib/diameter/src/compiler/diameter_codegen.erl')

diff --git a/lib/diameter/src/compiler/diameter_codegen.erl b/lib/diameter/src/compiler/diameter_codegen.erl
index f2c10f1748..91bab2205c 100644
--- a/lib/diameter/src/compiler/diameter_codegen.erl
+++ b/lib/diameter/src/compiler/diameter_codegen.erl
@@ -50,6 +50,7 @@
 
 -spec from_dict(File, ParseD, Opts, Mode)
    -> ok
+    | list()
  when File :: string(),
       ParseD :: orddict:orddict(),
       Opts :: list(),
@@ -57,13 +58,51 @@
 
 from_dict(File, ParseD, Opts, Mode) ->
     Outdir = proplists:get_value(outdir, Opts, "."),
+    Return = proplists:get_value(return, Opts, false),
+    Mod = mod(File, orddict:find(name, ParseD)),
     putr(verbose, lists:member(verbose, Opts)),
     try
-        codegen(File, ParseD, Outdir, Mode)
+        maybe_write(Return, Mode, Outdir, Mod, gen(Mode, ParseD, ?A(Mod)))
     after
         eraser(verbose)
     end.
 
+mod(File, error) ->
+    filename:rootname(filename:basename(File));
+mod(_, {ok, Mod}) ->
+    Mod.
+
+maybe_write(true, _, _, _, T) ->
+    T;
+maybe_write(_, Mode, Outdir, Mod, T) ->
+    Path = filename:join(Outdir, Mod),  %% minus extension
+    do_write(Mode, [Path, $., ext(Mode)], T).
+
+ext(dict) ->
+    "D";
+ext(forms) ->
+    "F";
+ext(T) ->
+    ?S(T).
+
+do_write(M, Path, T)
+  when M == dict;
+       M == forms ->
+    write_term(Path, T);
+do_write(_, Path, T) ->
+    write(Path, T).
+
+write(Path, T) ->
+    write(Path, "~s", T).
+
+write_term(Path, T) ->
+    write(Path, "~p.~n", T).
+
+write(Path, Fmt, T) ->
+    {ok, Fd} = file:open(Path, [write]),
+    io:fwrite(Fd, Fmt, [T]),
+    ok = file:close(Fd).
+
 %% Optional reports when running verbosely.
 report(What, Data) ->
     report(getr(verbose), What, Data),
@@ -104,39 +143,17 @@ file(F, Outdir, Mode) ->
 get_value(Key, Plist) ->
     proplists:get_value(Key, Plist, []).
 
-codegen(File, ParseD, Outdir, Mode) ->
-    Mod = mod(File, orddict:find(name, ParseD)),
-    Path = filename:join(Outdir, Mod),  %% minus extension
-    gen(Mode, ParseD, ?A(Mod), Path),
-    ok.
-
-mod(File, error) ->
-    filename:rootname(filename:basename(File));
-mod(_, {ok, Mod}) ->
-    Mod.
-
-gen(dict, ParseD, _Mod, Path) ->
-    write_term(Path ++ ".D", [?VERSION | ParseD]);
-
-gen(hrl, ParseD, Mod, Path) ->
-    write(Path ++ ".hrl", gen_hrl(Mod, ParseD));
+gen(dict, ParseD, _Mod) ->
+    [?VERSION | ParseD];
 
-gen(forms, ParseD, Mod, Path) ->
-    write_term(Path ++ ".F", [erl_forms(Mod, ParseD)]);
+gen(hrl, ParseD, Mod) ->
+    gen_hrl(Mod, ParseD);
 
-gen(erl, ParseD, Mod, Path) ->
-    write(Path ++ ".erl", [header(), prettypr(erl_forms(Mod, ParseD)), $\n]).
+gen(forms, ParseD, Mod) ->
+    erl_forms(Mod, ParseD);
 
-write(Path, T) ->
-    write(Path, "~s", T).
-
-write_term(Path, T) ->
-    write(Path, "~p.~n", T).
-
-write(Path, Fmt, T) ->
-    {ok, Fd} = file:open(Path, [write]),
-    io:fwrite(Fd, Fmt, [T]),
-    file:close(Fd).
+gen(erl, ParseD, Mod) ->
+    [header(), prettypr(erl_forms(Mod, ParseD)), $\n].
 
 erl_forms(Mod, ParseD) ->
     Forms = [[{?attribute, module, Mod},
-- 
cgit v1.2.3