From 9a90f20f365a90612ee5e5f7db14fd71b4875b84 Mon Sep 17 00:00:00 2001
From: Anders Svensson <anders@erlang.org>
Date: Mon, 24 Apr 2017 11:07:27 +0200
Subject: Deal with (another) SCTP association id quirk on Solaris

Shutdown events have been seen to get a different association id.
For example, first incoming message with association id = 0:

+ {trace_ts,<6421.268.0>,call,
      {diameter_sctp,handle_info,
          [{sctp,#Port<6421.2588>,
               {10,67,16,179},
               44159,
               {[{sctp_sndrcvinfo,0,0,[],0,0,0,269950872,269950872,0}],
                <<1,0,0,156,128,0,1,1,0,0,0,0,6,193,40,137,6,193,40,137,0,0,
                  1,8,64,0,0,30,67,45,49,51,52,50,49,55,52,52,49,46,101,114,
                  108,97,110,103,46,111,114,103,0,0,0,0,1,40,64,0,0,18,101,
                  114,108,97,110,103,46,111,114,103,0,0,0,0,1,1,64,0,0,14,0,
                  1,127,0,0,1,0,0,0,0,1,10,64,0,0,12,0,0,48,57,0,0,1,13,0,0,
                  0,20,79,84,80,47,100,105,97,109,101,116,101,114,0,0,1,22,
                  64,0,0,12,0,0,0,1,0,0,1,2,64,0,0,12,0,0,0,0,0,0,1,3,64,0,0,
                  12,0,0,0,3>>}},
           {transport,<6421.252.0>,accept,#Port<6421.2588>,true,undefined,
               {32,32},
               0,undefined}]},
      {1493,21505,577938}}

Later, a shutdown event with association id 1536:

+ {trace_ts,<6421.268.0>,call,
      {diameter_sctp,handle_info,
          [{sctp,#Port<6421.2588>,
               {10,67,16,179},
               44159,
               {[],{sctp_shutdown_event,1536}}},
           {transport,<6421.252.0>,accept,#Port<6421.2588>,0,undefined,
               {32,32},
               2,<6421.304.0>}]},
      {1493,21505,746929}}

Both this and the grandparent commit are on this:

$ uname -a
SunOS beren 5.10 Generic_118833-33 sun4v sparc SUNW,Netra-T2000
---
 lib/diameter/src/transport/diameter_sctp.erl | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

(limited to 'lib/diameter/src')

diff --git a/lib/diameter/src/transport/diameter_sctp.erl b/lib/diameter/src/transport/diameter_sctp.erl
index 2059a0e029..1e64804666 100644
--- a/lib/diameter/src/transport/diameter_sctp.erl
+++ b/lib/diameter/src/transport/diameter_sctp.erl
@@ -709,11 +709,7 @@ recv({[#sctp_sndrcvinfo{stream = Id}], Bin}, #transport{parent = Pid} = S)
                                              bin = Bin}),
     S;
 
-recv({_, #sctp_shutdown_event{assoc_id = A}},
-     #transport{assoc_id = Id})
-  when Id;
-       A == Id;
-       A == 0 ->
+recv({_, #sctp_shutdown_event{}}, _) ->
     stop;
 
 %% Note that diameter_sctp(3) documents that sctp_events cannot be
-- 
cgit v1.2.3