From 3b72ab9407945eb7037c608ac2826b64ec17cdc6 Mon Sep 17 00:00:00 2001 From: Rickard Green Date: Mon, 13 Mar 2017 18:06:02 +0100 Subject: Fix xml warnings in old release notes --- lib/diameter/doc/src/notes.xml | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) (limited to 'lib/diameter') diff --git a/lib/diameter/doc/src/notes.xml b/lib/diameter/doc/src/notes.xml index c2bbed2e5a..28d6ea4fd0 100644 --- a/lib/diameter/doc/src/notes.xml +++ b/lib/diameter/doc/src/notes.xml @@ -255,8 +255,8 @@ first.

Fix decode of Grouped AVPs containing errors.

RFC 6733 says this of Failed-AVP in 7.5:

-

-

In the case where the offending AVP + +

In the case where the offending AVP is embedded within a Grouped AVP, the Failed-AVP MAY contain the grouped AVP, which in turn contains the single offending AVP. The same method MAY be employed if @@ -265,11 +265,11 @@ first.

the grouped AVP hierarchy up to the single offending AVP. This enables the recipient to detect the location of the offending AVP when embedded in a - group.

+ group.

It says this of DIAMETER_INVALID_AVP_LENGTH in 7.1.5:

-

-

The request contained an AVP with + +

The request contained an AVP with an invalid length. A Diameter message indicating this error MUST include the offending AVPs within a Failed-AVP AVP. In cases where the erroneous AVP length value @@ -284,7 +284,8 @@ first.

the minimum AVP header length, it is sufficient to include an offending AVP header that is formulated by padding the incomplete AVP header with zero up to the - minimum AVP header length.

+ minimum AVP header length.

+

The AVPs placed in the errors field of a diameter_packet record are intended to be appropriate for inclusion in a @@ -949,8 +950,8 @@ first.

Be lenient with the M-bit in Grouped AVPs.

RFC 6733 says this, in 4.4:

-

-

Receivers of a Grouped AVP that does + +

Receivers of a Grouped AVP that does not have the 'M' (mandatory) bit set and one or more of the encapsulated AVPs within the group has the 'M' (mandatory) bit set MAY simply be ignored if the Grouped @@ -958,14 +959,14 @@ first.

encapsulated AVP with its 'M' (mandatory) bit set is further encapsulated within other sub-groups, i.e., other Grouped AVPs embedded within the Grouped - AVP.

+ AVP.

The first sentence is mangled but take it to mean this:

-

-

An unrecognized AVP of type Grouped + +

An unrecognized AVP of type Grouped that does not set the 'M' bit MAY be ignored even if one of its encapsulated AVPs sets the 'M' - bit.

+ bit.

This is a bit of a non-statement since if the AVP is unrecognized then its type is unknown. We therefore don't -- cgit v1.2.3