From 6aabb5176a176f3413a446ad13178eb25c4c90fd Mon Sep 17 00:00:00 2001
From: Anders Svensson <anders@erlang.org>
Date: Mon, 23 Feb 2015 23:19:13 +0100
Subject: Fix SCTP match blunder in suites

More than an incoming message can contain ancillary data, which the
gen_sctp and transport suites did not expect. On FreeBSD 10, an
sctp_assoc_change event appears always to contain ancillary data.
---
 lib/diameter/test/diameter_gen_sctp_SUITE.erl  | 30 +++++++++++++-------------
 lib/diameter/test/diameter_transport_SUITE.erl |  6 +++++-
 2 files changed, 20 insertions(+), 16 deletions(-)

(limited to 'lib/diameter')

diff --git a/lib/diameter/test/diameter_gen_sctp_SUITE.erl b/lib/diameter/test/diameter_gen_sctp_SUITE.erl
index 51ccb1e6ec..25017272b5 100644
--- a/lib/diameter/test/diameter_gen_sctp_SUITE.erl
+++ b/lib/diameter/test/diameter_gen_sctp_SUITE.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 2010-2013. All Rights Reserved.
+%% Copyright Ericsson AB 2010-2015. All Rights Reserved.
 %%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -119,10 +119,10 @@ send_not_from_controlling_process(_) ->
 
 send_not_from_controlling_process() ->
     FPid = self(),
-    {L, MRef} = spawn_monitor(fun() -> listen(FPid) end),%% listening process
+    {L, MRef} = spawn_monitor(fun() -> listen(FPid) end),
     receive
         {?MODULE, C, S} ->
-            erlang:demonitor(MRef, [flush]),
+            demonitor(MRef, [flush]),
             [L,C,S];
         {'DOWN', MRef, process, _, _} = T ->
             error(T)
@@ -137,13 +137,7 @@ listen(FPid) ->
     LPid = self(),
     spawn(fun() -> connect1(PortNr, FPid, LPid) end), %% connecting process
     Id = assoc(Sock),
-    ?SCTP(Sock, {[#sctp_sndrcvinfo{assoc_id = Id}], _Bin})
-        = recv(). %% Waits with this as current_function.
-
-%% recv/0
-
-recv() ->
-    receive T -> T end.
+    recv(Sock, Id).
 
 %% connect1/3
 
@@ -154,7 +148,7 @@ connect1(PortNr, FPid, LPid) ->
     FPid ! {?MODULE,
             self(),
             spawn(fun() -> send(Sock, Id) end)}, %% sending process
-    MRef = erlang:monitor(process, LPid),
+    MRef = monitor(process, LPid),
     down(MRef).  %% Waits with this as current_function.
 
 %% down/1
@@ -277,7 +271,8 @@ acc(N, Acc) ->
 
 loop(Sock, MRef, Bin) ->
     receive
-        ?SCTP(Sock, {[#sctp_sndrcvinfo{assoc_id = Id}], B}) ->
+        ?SCTP(Sock, {[#sctp_sndrcvinfo{assoc_id = Id}], B})
+          when is_binary(B) ->
             Sz = size(Bin),
             {Sz, Bin} = {size(B), B},  %% assert
             ok = send(Sock, Id, mark(Bin)),
@@ -291,7 +286,7 @@ loop(Sock, MRef, Bin) ->
 %% connect2/3
 
 connect2(Pid, PortNr, Bin) ->
-    erlang:monitor(process, Pid),
+    monitor(process, Pid),
 
     {ok, Sock} = open(),
     ok = gen_sctp:connect_init(Sock, ?ADDR, PortNr, []),
@@ -311,9 +306,14 @@ connect2(Pid, PortNr, Bin) ->
 
 recv(Sock, Id) ->
     receive
-        ?SCTP(Sock, {[#sctp_sndrcvinfo{assoc_id = Id}], Bin}) ->
+        ?SCTP(Sock, {[#sctp_sndrcvinfo{assoc_id = I}], Bin})
+          when is_binary(Bin) ->
+            Id = I,   %% assert
             Bin;
-        T ->  %% eg. 'DOWN'
+        ?SCTP(S, _) ->
+            Sock = S, %% assert
+            recv(Sock, Id);
+        T ->
             exit(T)
     end.
 
diff --git a/lib/diameter/test/diameter_transport_SUITE.erl b/lib/diameter/test/diameter_transport_SUITE.erl
index 64015f3336..84ab6cbdc4 100644
--- a/lib/diameter/test/diameter_transport_SUITE.erl
+++ b/lib/diameter/test/diameter_transport_SUITE.erl
@@ -424,7 +424,11 @@ gen_send(tcp, Sock, Bin) ->
 
 gen_recv(sctp, Sock) ->
     {_OS, _IS, Id} = getr(assoc),
-    ?RECV(?SCTP(Sock, {[#sctp_sndrcvinfo{assoc_id = Id}], Bin}), Bin);
+    receive
+        ?SCTP(Sock, {[#sctp_sndrcvinfo{assoc_id = Id}], Bin})
+          when is_binary(Bin) ->
+            Bin
+    end;
 gen_recv(tcp, Sock) ->
     tcp_recv(Sock, <<>>).
 
-- 
cgit v1.2.3