From c30eb71556cd569fea82de2a1c2a5a17e71650c1 Mon Sep 17 00:00:00 2001
From: Micael Karlberg <bmk@erlang.org>
Date: Tue, 18 Oct 2011 17:47:53 +0200
Subject: [httpc] Wrong Host header in IPv6 HTTP requests. When a URI with a
 IPv6 host is parsed, the brackets that encapsulates the nnn is removed. This
 value is then supplied as the host header. This can cause problems with some
 servers. A workaround for this is to use headers_as_is and provide the host
 header with the requst call To solve this a new option has been added,
 ipv6_host_with_brackets. This option specifies if the host value of the host
 header shall include the branckets or not. By default, it does not (as
 before). OTP-9628

---
 lib/inets/src/http_lib/http_uri.erl | 35 ++++++++++++++++++++++++-----------
 1 file changed, 24 insertions(+), 11 deletions(-)

(limited to 'lib/inets/src/http_lib')

diff --git a/lib/inets/src/http_lib/http_uri.erl b/lib/inets/src/http_lib/http_uri.erl
index 5fa23ceb2d..74ffa37ca4 100644
--- a/lib/inets/src/http_lib/http_uri.erl
+++ b/lib/inets/src/http_lib/http_uri.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 2006-2010. All Rights Reserved.
+%% Copyright Ericsson AB 2006-2011. All Rights Reserved.
 %%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -22,17 +22,22 @@
 
 -module(http_uri).
 
--export([parse/1, encode/1, decode/1]).
+-export([parse/1, parse/2, 
+	 encode/1, decode/1]).
+
 
 %%%=========================================================================
 %%%  API
 %%%=========================================================================
 parse(AbsURI) ->
+    parse(AbsURI, []).
+
+parse(AbsURI, Opts) ->
     case parse_scheme(AbsURI) of
 	{error, Reason} ->
 	    {error, Reason};
 	{Scheme, Rest} ->
-	    case (catch parse_uri_rest(Scheme, Rest)) of
+	    case (catch parse_uri_rest(Scheme, Rest, Opts)) of
 		{UserInfo, Host, Port, Path, Query} ->
 		    {ok, {Scheme, UserInfo, Host, Port, Path, Query}};
 		_  ->
@@ -64,15 +69,14 @@ parse_scheme(AbsURI) ->
 	    {error, no_scheme};
 	{StrScheme, Rest} ->
 	    case list_to_atom(http_util:to_lower(StrScheme)) of
-		Scheme when Scheme == http; Scheme == https ->
+		Scheme when (Scheme =:= http) orelse (Scheme =:= https) ->
 		    {Scheme, Rest};
 		Scheme ->
 		    {error, {not_supported_scheme, Scheme}}
 	    end
     end.
 
-parse_uri_rest(Scheme, "//" ++ URIPart) ->
-
+parse_uri_rest(Scheme, "//" ++ URIPart, Opts) ->
     {Authority, PathQuery} =
 	case split_uri(URIPart, "/", URIPart, 1, 0) of
 	    Split = {_, _} ->
@@ -87,8 +91,8 @@ parse_uri_rest(Scheme, "//" ++ URIPart) ->
 	end,
 
     {UserInfo, HostPort} = split_uri(Authority, "@", {"", Authority}, 1, 1),
-    {Host, Port} = parse_host_port(Scheme, HostPort),
-    {Path, Query} = parse_path_query(PathQuery),
+    {Host, Port}         = parse_host_port(Scheme, HostPort, Opts),
+    {Path, Query}        = parse_path_query(PathQuery),
     {UserInfo, Host, Port, Path, Query}.
 
 
@@ -96,13 +100,14 @@ parse_path_query(PathQuery) ->
     {Path, Query} =  split_uri(PathQuery, "\\?", {PathQuery, ""}, 1, 0),
     {path(Path), Query}.
 
-parse_host_port(Scheme,"[" ++ HostPort) -> %ipv6
+parse_host_port(Scheme,"[" ++ HostPort, Opts) -> %ipv6
     DefaultPort = default_port(Scheme),
     {Host, ColonPort} = split_uri(HostPort, "\\]", {HostPort, ""}, 1, 1),
+    Host2 = maybe_ipv6_host_with_brackets(Host, Opts),
     {_, Port} = split_uri(ColonPort, ":", {"", DefaultPort}, 0, 1),
-    {Host, int_port(Port)};
+    {Host2, int_port(Port)};
 
-parse_host_port(Scheme, HostPort) ->
+parse_host_port(Scheme, HostPort, _Opts) ->
     DefaultPort = default_port(Scheme),
     {Host, Port} = split_uri(HostPort, ":", {HostPort, DefaultPort}, 1, 1),
     {Host, int_port(Port)}.
@@ -116,6 +121,14 @@ split_uri(UriPart, SplitChar, NoMatchResult, SkipLeft, SkipRight) ->
 	    NoMatchResult
     end.
 
+maybe_ipv6_host_with_brackets(Host, Opts) ->
+    case lists:keysearch(ipv6_host_with_brackets, 1, Opts) of
+	{value, {ipv6_host_with_brackets, true}} ->
+	    "[" ++ Host ++ "]";
+	_ ->
+	    Host
+    end.
+
 default_port(http) ->
     80;
 default_port(https) ->
-- 
cgit v1.2.3