From b314eeff3dd14f046a18305ccd68371108936244 Mon Sep 17 00:00:00 2001
From: Ingela Anderton Andin <ingela@erlang.org>
Date: Tue, 7 Apr 2015 10:51:04 +0200
Subject: inets: Remove SSI (Server Side Includes)

SSI is an old technique implemented by mod_include, that was badly
tested and not recommended to use, as having the server parse HTML
pages is a double edged sword!  It can be costly for a heavily loaded
server to perform parsing of HTML pages while sending
them. Furthermore, it can be considered a security risk to have
average users executing commands in the name of the Erlang node user.
---
 lib/inets/test/httpd_SUITE.erl     | 17 -----------------
 lib/inets/test/old_httpd_SUITE.erl |  6 +++---
 2 files changed, 3 insertions(+), 20 deletions(-)

(limited to 'lib/inets/test')

diff --git a/lib/inets/test/httpd_SUITE.erl b/lib/inets/test/httpd_SUITE.erl
index 342004f19b..11f2c6f298 100644
--- a/lib/inets/test/httpd_SUITE.erl
+++ b/lib/inets/test/httpd_SUITE.erl
@@ -127,7 +127,6 @@ http_get() ->
      get, 
      %%actions, Add configuration so that this test mod_action
      esi, 
-     ssi, 
      content_length, 
      bad_hex, 
      missing_CR,
@@ -552,22 +551,6 @@ ipv6(Config) when is_list(Config) ->
      end.
 
 %%-------------------------------------------------------------------------
-ssi() ->
-    [{doc, "HTTP GET server side include test"}].
-ssi(Config) when is_list(Config) -> 
-    Version = ?config(http_version, Config),
-    Host = ?config(host, Config),
-    Type = ?config(type, Config),
-    ok = httpd_test_lib:verify_request(?config(type, Config), Host, ?config(port, Config),  
-				       transport_opts(Type, Config),
-				       ?config(node, Config),
-				       http_request("GET /fsize.shtml ", Version, Host),
-				       [{statuscode, 200},
-					{header, "Content-Type", "text/html"},
-					{header, "Date"},
-					{header, "Server"},
-				       	{version, Version}]).
-%%-------------------------------------------------------------------------
 htaccess_1_1(Config) when is_list(Config) -> 
     htaccess([{http_version, "HTTP/1.1"} | Config]).
 
diff --git a/lib/inets/test/old_httpd_SUITE.erl b/lib/inets/test/old_httpd_SUITE.erl
index 74c11f71ba..39b0b08645 100644
--- a/lib/inets/test/old_httpd_SUITE.erl
+++ b/lib/inets/test/old_httpd_SUITE.erl
@@ -2072,13 +2072,13 @@ create_config(Config, Access, FileName) ->
 		"Modules mod_alias mod_htaccess mod_auth "
 		    "mod_security "
 		    "mod_responsecontrol mod_trace mod_esi "
-		    "mod_actions mod_cgi mod_include mod_dir "
+		    "mod_actions mod_cgi mod_dir "
 		    "mod_range mod_get "
 		    "mod_head mod_log mod_disk_log";
 	    _ ->
 		"Modules mod_alias mod_auth mod_security "
 		    "mod_responsecontrol mod_trace mod_esi "
-		    "mod_actions mod_cgi mod_include mod_dir "
+		    "mod_actions mod_cgi mod_dir "
 			   "mod_range mod_get "
 		    "mod_head mod_log mod_disk_log"
 	end,
@@ -2436,7 +2436,7 @@ create_ipv6_config(Config, FileName, Ipv6Address) ->
     MaxHdrAct    = io_lib:format("~p", [close]),
   
     Mod_order = "Modules mod_alias mod_auth mod_esi mod_actions mod_cgi" 
-	" mod_include mod_dir mod_get mod_head" 
+	" mod_dir mod_get mod_head" 
 	" mod_log mod_disk_log mod_trace",
 	    
     SSL =
-- 
cgit v1.2.3