From c1780b76cdfefbb52025afcf27f6eab01a464e90 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Holger=20Wei=C3=9F?= <holger@zedat.fu-berlin.de>
Date: Thu, 9 Apr 2015 21:24:32 +0200
Subject: Don't throw exception on prim_inet:setopt/3 error

Let gen_tcp:controlling_process/2 and inet_sctp:connect/[45] propagate
prim_inet:setopt/3 errors instead of having them generate badmatch
exceptions.
---
 lib/kernel/src/inet.erl      | 24 +++++++++++++-----------
 lib/kernel/src/inet_sctp.erl | 19 +++++++++++--------
 2 files changed, 24 insertions(+), 19 deletions(-)

(limited to 'lib/kernel/src')

diff --git a/lib/kernel/src/inet.erl b/lib/kernel/src/inet.erl
index ec2c350931..d668738109 100644
--- a/lib/kernel/src/inet.erl
+++ b/lib/kernel/src/inet.erl
@@ -1527,26 +1527,28 @@ tcp_controlling_process(S, NewOwner) when is_port(S), is_pid(NewOwner) ->
 	_ ->
 	    case prim_inet:getopt(S, active) of
 		{ok, A0} ->
-		    case A0 of
-			false -> ok;
-			_ -> ok = prim_inet:setopt(S, active, false)
-		    end,
-		    case tcp_sync_input(S, NewOwner, false) of
-			true ->  %% socket already closed, 
+		    SetOptRes =
+			case A0 of
+			    false -> ok;
+			    _ -> prim_inet:setopt(S, active, false)
+			end,
+		    case {tcp_sync_input(S, NewOwner, false), SetOptRes} of
+			{true, _} ->  %% socket already closed
 			    ok;
-			false ->
+			{false, ok} ->
 			    try erlang:port_connect(S, NewOwner) of
 				true -> 
 				    unlink(S), %% unlink from port
 				    case A0 of
 					false -> ok;
-					_ -> ok = prim_inet:setopt(S, active, A0)
-				    end,
-				    ok
+					_ -> prim_inet:setopt(S, active, A0)
+				    end
 			    catch
 				error:Reason -> 
 				    {error, Reason}
-			    end
+			    end;
+			{false, Error} ->
+			    Error
 		    end;
 		Error ->
 		    Error
diff --git a/lib/kernel/src/inet_sctp.erl b/lib/kernel/src/inet_sctp.erl
index 93528d305d..f0f13c8d4a 100644
--- a/lib/kernel/src/inet_sctp.erl
+++ b/lib/kernel/src/inet_sctp.erl
@@ -133,15 +133,18 @@ connect_get_assoc(S, Addr, Port, Active, Timer) ->
     Timeout = inet:timeout(Timer),
     receive
 	{sctp,S,Addr,Port,{_,#sctp_assoc_change{state=St}=Ev}} ->
-	    case Active of
-		once ->
-		    ok = prim_inet:setopt(S, active, once);
-		_ -> ok
-	    end,
-	    if St =:= comm_up ->
+	    SetOptRes =
+		case Active of
+		    once -> prim_inet:setopt(S, active, once);
+		    _ -> ok
+		end,
+	    case {St, SetOptRes} of
+		{comm_up, ok} ->
 		    {ok,Ev};
-	       true ->
-		    {error,Ev}
+		{_, ok} ->
+		    {error,Ev};
+		{_, Error} ->
+		    Error
 	    end
     after Timeout ->
 	    {error,timeout}
-- 
cgit v1.2.3