From 397e69fa95457f9660831ba1e551c784eb61e93e Mon Sep 17 00:00:00 2001
From: Dan Gudmundsson <dgud@erlang.org>
Date: Tue, 18 Feb 2014 17:21:55 +0100
Subject: kernel: Fix an application terminate deadlock possibility

Could happen if get_child was called during terminate.
io (since it is a group_leader) also causes problems after
get_child was called.

Split up and do it async.
---
 lib/kernel/test/application_SUITE_data/deadlock/deadlock.app |  2 +-
 lib/kernel/test/application_SUITE_data/deadlock/deadlock.erl | 12 +++++++++++-
 2 files changed, 12 insertions(+), 2 deletions(-)

(limited to 'lib/kernel/test/application_SUITE_data')

diff --git a/lib/kernel/test/application_SUITE_data/deadlock/deadlock.app b/lib/kernel/test/application_SUITE_data/deadlock/deadlock.app
index 0c1001bed6..233c7a3f76 100644
--- a/lib/kernel/test/application_SUITE_data/deadlock/deadlock.app
+++ b/lib/kernel/test/application_SUITE_data/deadlock/deadlock.app
@@ -4,5 +4,5 @@
   {applications, [kernel, stdlib, sasl]},
   {modules, [deadlock]},
   {mod, {deadlock, []}},
-  {env, [{fail_start, false}]}
+  {env, [{fail_start, false}, {fail_stop, false}]}
 ]}.
diff --git a/lib/kernel/test/application_SUITE_data/deadlock/deadlock.erl b/lib/kernel/test/application_SUITE_data/deadlock/deadlock.erl
index 5f68bf9078..3ef6105371 100644
--- a/lib/kernel/test/application_SUITE_data/deadlock/deadlock.erl
+++ b/lib/kernel/test/application_SUITE_data/deadlock/deadlock.erl
@@ -21,7 +21,7 @@ init([sup]) ->
     {ok, {{one_for_one, 5, 10}, [
         {
             sasl_syslog_dm, {?MODULE, start_link, []},
-            permanent, brutal_kill, worker,
+            permanent, 25000, worker,
             [deadlock]
         }
     ]}};
@@ -32,6 +32,8 @@ init([sup]) ->
 init([child]) ->
     case application:get_env(deadlock, fail_start) of
         {ok, false} ->
+	    process_flag(trap_exit, true),
+	    io:format("~p: Traps exit~n",[?MODULE]),
             %% we must not fail on the first init, otherwise supervisor
             %% terminates immediately
             {ok, []};
@@ -50,6 +52,14 @@ handle_info(_Msg, State) ->
     {noreply, State}.
 
 terminate(_Reason, _State) ->
+    case application:get_env(deadlock, fail_stop) of
+        {ok, false} -> ok;
+        {ok, Tester}  ->
+	    Tester ! {deadlock, self()},
+	    io:format("~p: Waiting in terminate (~p)~n",[?MODULE,Tester]),
+	    receive continue -> ok end
+    end,
+    io:format("~p: terminates~n", [?MODULE]),
     ok.
 
 code_change(_OldVsn, State, _Extra) ->
-- 
cgit v1.2.3