From 25952bf726e4dc20fb3e2067e0b92c55932ce616 Mon Sep 17 00:00:00 2001
From: Zandra Norman <zandra@erlang.org>
Date: Fri, 28 Apr 2017 12:12:52 +0200
Subject: kernel: Do not allow unicode in nodenames

Verify that unicode isn't used in a node name and logi an info
message if it is. Filter the head part of the name a bit harder
to work with epmd.
---
 lib/kernel/test/erl_distribution_SUITE.erl | 99 ++++++++++++++++++++++++++++--
 1 file changed, 95 insertions(+), 4 deletions(-)

(limited to 'lib/kernel/test/erl_distribution_SUITE.erl')

diff --git a/lib/kernel/test/erl_distribution_SUITE.erl b/lib/kernel/test/erl_distribution_SUITE.erl
index 09c80a0956..ecfa3d6cdb 100644
--- a/lib/kernel/test/erl_distribution_SUITE.erl
+++ b/lib/kernel/test/erl_distribution_SUITE.erl
@@ -24,7 +24,9 @@
 -export([all/0, suite/0,groups/0,init_per_suite/1, end_per_suite/1, 
 	 init_per_group/2,end_per_group/2]).
 
--export([tick/1, tick_change/1, illegal_nodenames/1, hidden_node/1,
+-export([tick/1, tick_change/1,
+         nodenames/1, hostnames/1,
+         illegal_nodenames/1, hidden_node/1,
 	 setopts/1,
 	 table_waste/1, net_setuptime/1,
 	 inet_dist_options_options/1,
@@ -53,7 +55,6 @@
 
 -export([pinger/1]).
 
-
 -define(DUMMY_NODE,dummy@test01).
 
 %%-----------------------------------------------------------------
@@ -68,8 +69,8 @@ suite() ->
      {timetrap,{minutes,4}}].
 
 all() -> 
-    [tick, tick_change, illegal_nodenames, hidden_node,
-     setopts,
+    [tick, tick_change, nodenames, hostnames, illegal_nodenames,
+     hidden_node, setopts,
      table_waste, net_setuptime, inet_dist_options_options,
      {group, monitor_nodes}].
 
@@ -179,7 +180,97 @@ table_waste(Config) when is_list(Config) ->
     stop_node(N),
     ok.
 
+%% Test that starting nodes with different legal name part works, and that illegal
+%% ones are filtered
+nodenames(Config) when is_list(Config) ->
+    legal("a1@b"),
+    legal("a-1@b"),
+    legal("a_1@b"),
+
+    illegal("cdé@a"),
+    illegal("te欢st@a").
+
+%% Test that starting nodes with different legal host part works, and that illegal
+%% ones are filtered
+hostnames(Config) when is_list(Config) ->
+    Host = gethostname(),
+    legal([$a,$@|atom_to_list(Host)]),
+    legal("1@b1"),
+    legal("b@b1-c"),
+    legal("c@b1_c"),
+    legal("d@b1#c"),
+    legal("f@::1"),
+    legal("g@1:bc3:4e3f:f20:0:1"),
+
+    case file:native_name_encoding() of
+        latin1 -> ignore;
+        _ -> legal("e@b1é")
+    end,
+    long_hostnames(net_kernel:longnames()),
+
+    illegal("h@testالع"),
+    illegal("i@языtest"),
+    illegal("j@te欢st").
+
+long_hostnames(true) ->
+    legal("k@b.b.c"),
+    legal("l@b.b-c.d"),
+    legal("m@b.b_c.d"),
+    legal("n@127.0.0.1"),
+    legal("o@207.123.456.789");
+long_hostnames(false) ->
+    illegal("k@b.b.c").
+
+legal(Name) ->
+    case test_node(Name) of
+        started ->
+            ok;
+        not_started ->
+            ct:fail("no ~p node started", [Name])
+    end.
+
+illegal(Name) ->
+    case test_node(Name) of
+        not_started ->
+            ok;
+        started ->
+            ct:fail("~p node started with illegal name", [Name])
+    end.
 
+test_node(Name) ->
+    ProgName = atom_to_list(lib:progname()),
+    Command = ProgName ++ " -noinput " ++ long_or_short() ++ Name ++
+               " -eval \"net_adm:ping('" ++ atom_to_list(node()) ++ "')\"",
+    net_kernel:monitor_nodes(true),
+    BinCommand = unicode:characters_to_binary(Command, utf8),
+    open_port({spawn, BinCommand}, [stream]),
+    Node = list_to_atom(Name),
+    receive
+        {nodeup, Node} ->
+            net_kernel:monitor_nodes(false),
+            slave:stop(Node),
+            started
+    after 5000 ->
+        net_kernel:monitor_nodes(false),
+        not_started
+    end.
+
+long_or_short() ->
+    case net_kernel:longnames() of
+        true -> " -name ";
+        false -> " -sname "
+    end.
+
+% get the localhost's name, depending on the using name policy
+gethostname() ->
+    Hostname = case net_kernel:longnames() of
+       true->
+           net_adm:localhost();
+       _->
+           {ok, Name}=inet:gethostname(),
+           Name
+    end,
+    list_to_atom(Hostname).
 
 %% Test that pinging an illegal nodename does not kill the node.
 illegal_nodenames(Config) when is_list(Config) ->
-- 
cgit v1.2.3