From 127f970059371d968238c8e461bc5c547b021899 Mon Sep 17 00:00:00 2001
From: Rickard Green <rickard@erlang.org>
Date: Tue, 30 Apr 2013 12:56:50 +0200
Subject: Make high_msgq_watermark and low_msgq_watermark generic inet options

---
 lib/kernel/doc/src/inet.xml            | 4 ++--
 lib/kernel/src/gen_sctp.erl            | 4 ++++
 lib/kernel/src/gen_udp.erl             | 4 ++++
 lib/kernel/src/inet.erl                | 5 +++--
 lib/kernel/src/inet_int.hrl            | 4 ++--
 lib/kernel/test/inet_sockopt_SUITE.erl | 8 ++++++--
 6 files changed, 21 insertions(+), 8 deletions(-)

(limited to 'lib/kernel')

diff --git a/lib/kernel/doc/src/inet.xml b/lib/kernel/doc/src/inet.xml
index 541500a300..7cd98914d1 100644
--- a/lib/kernel/doc/src/inet.xml
+++ b/lib/kernel/doc/src/inet.xml
@@ -559,7 +559,7 @@ fe80::204:acff:fe17:bf38
               <c>[Byte1,Byte2|Binary]</c>.</p>
           </item>
 
-          <tag><c>{high_msgq_watermark, Size}</c> (TCP/IP sockets)</tag>
+          <tag><c>{high_msgq_watermark, Size}</c></tag>
           <item>
 	    <p>The socket message queue will be set into a busy
 	    state when the amount of data queued on the message
@@ -674,7 +674,7 @@ fe80::204:acff:fe17:bf38
 				  the flushing time-out in seconds.</p>
 		  </item>
 
-          <tag><c>{low_msgq_watermark, Size}</c> (TCP/IP sockets)</tag>
+          <tag><c>{low_msgq_watermark, Size}</c></tag>
           <item>
 	    <p>If the socket message queue is in a busy state, the
 	    socket message queue will be set in a not busy state when
diff --git a/lib/kernel/src/gen_sctp.erl b/lib/kernel/src/gen_sctp.erl
index 74ad192802..acc116df84 100644
--- a/lib/kernel/src/gen_sctp.erl
+++ b/lib/kernel/src/gen_sctp.erl
@@ -39,7 +39,9 @@
         {active, true | false | once} |
         {buffer, non_neg_integer()} |
         {dontroute, boolean()} |
+        {high_msgq_watermark, pos_integer()} |
         {linger, {boolean(), non_neg_integer()}} |
+        {low_msgq_watermark, pos_integer()} |
         {mode, list | binary} | list | binary |
         {priority, non_neg_integer()} |
         {recbuf, non_neg_integer()} |
@@ -68,7 +70,9 @@
         active |
         buffer |
         dontroute |
+        high_msgq_watermark |
         linger |
+        low_msgq_watermark |
         mode |
         priority |
         recbuf |
diff --git a/lib/kernel/src/gen_udp.erl b/lib/kernel/src/gen_udp.erl
index c5a1173575..fb5737f82e 100644
--- a/lib/kernel/src/gen_udp.erl
+++ b/lib/kernel/src/gen_udp.erl
@@ -34,6 +34,8 @@
         {dontroute,       boolean()} |
         {drop_membership, {inet:ip_address(), inet:ip_address()}} |
         {header,          non_neg_integer()} |
+        {high_msgq_watermark, pos_integer()} |
+        {low_msgq_watermark, pos_integer()} |
         {mode,            list | binary} | list | binary |
         {multicast_if,    inet:ip_address()} |
         {multicast_loop,  boolean()} |
@@ -56,6 +58,8 @@
         deliver |
         dontroute |
         header |
+        high_msgq_watermark |
+        low_msgq_watermark |
         mode |
         multicast_if |
         multicast_loop |
diff --git a/lib/kernel/src/inet.erl b/lib/kernel/src/inet.erl
index 9670271b2e..aada1252ad 100644
--- a/lib/kernel/src/inet.erl
+++ b/lib/kernel/src/inet.erl
@@ -712,7 +712,8 @@ udp_options() ->
     [tos, priority, reuseaddr, sndbuf, recbuf, header, active, buffer, mode, 
      deliver, ipv6_v6only,
      broadcast, dontroute, multicast_if, multicast_ttl, multicast_loop,
-     add_membership, drop_membership, read_packets,raw].
+     add_membership, drop_membership, read_packets,raw,
+     high_msgq_watermark, low_msgq_watermark].
 
 
 udp_options(Opts, Family) ->
@@ -766,7 +767,7 @@ udp_add(Name, Val, R, Opts, As) ->
 sctp_options() ->
 [   % The following are generic inet options supported for SCTP sockets:
     mode, active, buffer, tos, priority, dontroute, reuseaddr, linger, sndbuf,
-    recbuf, ipv6_v6only,
+    recbuf, ipv6_v6only, high_msgq_watermark, low_msgq_watermark,
 
     % Other options are SCTP-specific (though they may be similar to their
     % TCP and UDP counter-parts):
diff --git a/lib/kernel/src/inet_int.hrl b/lib/kernel/src/inet_int.hrl
index 000119bc74..a01c733d81 100644
--- a/lib/kernel/src/inet_int.hrl
+++ b/lib/kernel/src/inet_int.hrl
@@ -141,8 +141,8 @@
 -define(INET_LOPT_READ_PACKETS,  33).
 -define(INET_OPT_RAW,            34).
 -define(INET_LOPT_TCP_SEND_TIMEOUT_CLOSE, 35).
--define(INET_LOPT_TCP_MSGQ_HIWTRMRK,  36).
--define(INET_LOPT_TCP_MSGQ_LOWTRMRK,  37).
+-define(INET_LOPT_MSGQ_HIWTRMRK,  36).
+-define(INET_LOPT_MSGQ_LOWTRMRK,  37).
 % Specific SCTP options: separate range:
 -define(SCTP_OPT_RTOINFO,	 	100).
 -define(SCTP_OPT_ASSOCINFO,	 	101).
diff --git a/lib/kernel/test/inet_sockopt_SUITE.erl b/lib/kernel/test/inet_sockopt_SUITE.erl
index 75496ce745..185751fead 100644
--- a/lib/kernel/test/inet_sockopt_SUITE.erl
+++ b/lib/kernel/test/inet_sockopt_SUITE.erl
@@ -772,8 +772,10 @@ all_listen_options() ->
      {mode,list,binary,true,true}, 
      {deliver,term,port,true,true}, 
      {exit_on_close, true, false, true, true},
-     %{high_watermark,4096,8192,true,true}, 
-     %{low_watermark,2048,4096,true,true}, 
+     {high_watermark,4096,8192,true,true}, 
+     {low_watermark,2048,4096,true,true}, 
+     {high_msgq_watermark,4096,8192,true,true}, 
+     {low_msgq_watermark,2048,4096,true,true}, 
      {send_timeout,infinity,1000,true,true},
      {send_timeout_close,false,true,true,true},
      {delay_send,false,true,true,true}, 
@@ -797,6 +799,8 @@ all_connect_options() ->
      {exit_on_close, true, false, true, true},
      {high_watermark,4096,8192,false,true}, 
      {low_watermark,2048,4096,false,true}, 
+     {high_msgq_watermark,4096,8192,true,true}, 
+     {low_msgq_watermark,2048,4096,true,true}, 
      {send_timeout,infinity,1000,true,true},
      {send_timeout_close,false,true,true,true},
      {delay_send,false,true,true,true}, 
-- 
cgit v1.2.3