From af8938714416c0b1393a0830fdc6e8a5ab4be87c Mon Sep 17 00:00:00 2001
From: Filipe David Manana <fdmanana@apache.org>
Date: Sun, 19 Jun 2011 21:16:45 +0100
Subject: Fix type of Packet arg of gen_tcp:send/2 and gen_udp:send/4

The type is marked as a binary() or a string() but in practice it can
be an iodata(). The test suite was updated to confirm the gen_tcp/2
and gen_udp:send/4 functions accept iodata() (iolists) packets.
---
 lib/kernel/src/gen_tcp.erl            |  2 +-
 lib/kernel/src/gen_udp.erl            |  2 +-
 lib/kernel/test/gen_tcp_api_SUITE.erl |  8 ++++++++
 lib/kernel/test/gen_udp_SUITE.erl     | 14 +++++++++++---
 4 files changed, 21 insertions(+), 5 deletions(-)

(limited to 'lib/kernel')

diff --git a/lib/kernel/src/gen_tcp.erl b/lib/kernel/src/gen_tcp.erl
index df326b59d6..8ab18c01b4 100644
--- a/lib/kernel/src/gen_tcp.erl
+++ b/lib/kernel/src/gen_tcp.erl
@@ -250,7 +250,7 @@ close(S) ->
 
 -spec send(Socket, Packet) -> ok | {error, Reason} when
       Socket :: socket(),
-      Packet :: string() | binary(),
+      Packet :: iodata(),
       Reason :: inet:posix().
 
 send(S, Packet) when is_port(S) ->
diff --git a/lib/kernel/src/gen_udp.erl b/lib/kernel/src/gen_udp.erl
index 554f4ece4a..8688799ae9 100644
--- a/lib/kernel/src/gen_udp.erl
+++ b/lib/kernel/src/gen_udp.erl
@@ -109,7 +109,7 @@ close(S) ->
       Socket :: socket(),
       Address :: inet:ip_address() | inet:hostname(),
       Port :: inet:port_number(),
-      Packet :: string() | binary(),
+      Packet :: iodata(),
       Reason :: not_owner | inet:posix().
 
 send(S, Address, Port, Packet) when is_port(S) ->
diff --git a/lib/kernel/test/gen_tcp_api_SUITE.erl b/lib/kernel/test/gen_tcp_api_SUITE.erl
index fd4685cdad..cbaec2d6dd 100644
--- a/lib/kernel/test/gen_tcp_api_SUITE.erl
+++ b/lib/kernel/test/gen_tcp_api_SUITE.erl
@@ -158,6 +158,10 @@ t_shutdown_error(Config) when is_list(Config) ->
 
 t_fdopen(Config) when is_list(Config) ->
     ?line Question = "Aaaa... Long time ago in a small town in Germany,",
+    ?line Question1 = list_to_binary(Question),
+    ?line Question2 = [<<"Aaaa">>, "... ", $L, <<>>, $o, "ng time ago ",
+                       ["in ", [], <<"a small town">>, [" in Germany,", <<>>]]],
+    ?line Question1 = iolist_to_binary(Question2),
     ?line Answer = "there was a shoemaker, Schumacher was his name.",
     ?line {ok, L} = gen_tcp:listen(0, [{active, false}]),
     ?line {ok, Port} = inet:port(L),
@@ -167,6 +171,10 @@ t_fdopen(Config) when is_list(Config) ->
     ?line {ok, Server} = gen_tcp:fdopen(FD, []),
     ?line ok = gen_tcp:send(Client, Question),
     ?line {ok, Question} = gen_tcp:recv(Server, length(Question), 2000),
+    ?line ok = gen_tcp:send(Client, Question1),
+    ?line {ok, Question} = gen_tcp:recv(Server, length(Question), 2000),
+    ?line ok = gen_tcp:send(Client, Question2),
+    ?line {ok, Question} = gen_tcp:recv(Server, length(Question), 2000),
     ?line ok = gen_tcp:send(Server, Answer),
     ?line {ok, Answer} = gen_tcp:recv(Client, length(Answer), 2000),
     ?line ok = gen_tcp:close(Client),
diff --git a/lib/kernel/test/gen_udp_SUITE.erl b/lib/kernel/test/gen_udp_SUITE.erl
index b734d7fd98..514deaf065 100644
--- a/lib/kernel/test/gen_udp_SUITE.erl
+++ b/lib/kernel/test/gen_udp_SUITE.erl
@@ -201,13 +201,21 @@ binary_passive_recv(suite) ->
 binary_passive_recv(doc) ->
     ["OTP-3823 gen_udp:recv does not return address in binary mode"];
 binary_passive_recv(Config) when is_list(Config) ->
-    ?line D        = "The quick brown fox jumps over a lazy dog",
-    ?line B        = list_to_binary(D),
+    ?line D1       = "The quick brown fox jumps over a lazy dog",
+    ?line D2       = list_to_binary(D1),
+    ?line D3       = ["The quick", <<" brown ">>, "fox jumps ", <<"over ">>,
+                      <<>>, $a, [[], " lazy ", <<"dog">>]],
+    ?line D2       = iolist_to_binary(D3),
+    ?line B        = D2,
     ?line {ok, R}  = gen_udp:open(0, [binary, {active, false}]),
     ?line {ok, RP} = inet:port(R),
     ?line {ok, S}  = gen_udp:open(0),
     ?line {ok, SP} = inet:port(S),
-    ?line ok       = gen_udp:send(S, localhost, RP, D),
+    ?line ok       = gen_udp:send(S, localhost, RP, D1),
+    ?line {ok, {{127, 0, 0, 1}, SP, B}} = gen_udp:recv(R, byte_size(B)+1),
+    ?line ok       = gen_udp:send(S, localhost, RP, D2),
+    ?line {ok, {{127, 0, 0, 1}, SP, B}} = gen_udp:recv(R, byte_size(B)+1),
+    ?line ok       = gen_udp:send(S, localhost, RP, D3),
     ?line {ok, {{127, 0, 0, 1}, SP, B}} = gen_udp:recv(R, byte_size(B)+1),
     ?line ok       = gen_udp:close(S),
     ?line ok       = gen_udp:close(R),
-- 
cgit v1.2.3