From a83bf960f1018217d7f3c9c8387a37722aa93fc6 Mon Sep 17 00:00:00 2001
From: Dan Gudmundsson <dgud@erlang.org>
Date: Tue, 29 Apr 2014 10:09:08 +0200
Subject: mnesia: Replace catch with try-catch

Avoids building stacktraces where it is not needed and do
not mask errors, i.e. only catch the relevant classes in each try.
---
 lib/mnesia/src/mnesia.erl | 50 +++++++++++++++++++++++------------------------
 1 file changed, 24 insertions(+), 26 deletions(-)

(limited to 'lib/mnesia/src/mnesia.erl')

diff --git a/lib/mnesia/src/mnesia.erl b/lib/mnesia/src/mnesia.erl
index b7d80c1370..6917e196fa 100644
--- a/lib/mnesia/src/mnesia.erl
+++ b/lib/mnesia/src/mnesia.erl
@@ -145,7 +145,7 @@
 %% Local function in order to avoid external function call
 val(Var) ->
     case ?catch_val(Var) of
-	{'EXIT', Reason} -> mnesia_lib:other_val(Var, Reason);
+	{'EXIT', _} -> mnesia_lib:other_val(Var);
 	Value -> Value
     end.
 
@@ -807,7 +807,7 @@ next(Tid,Ts,Tab,Key)
 	tid ->
 	    lock_table(Tid, Ts, Tab, read),
 	    do_fixtable(Tab,Ts),
-	    New = (catch dirty_next(Tab,Key)),
+	    New = ?CATCH(dirty_next(Tab,Key)),
 	    stored_keys(Tab,New,Key,Ts,next,
 			val({Tab, setorbag}));
 	_Protocol ->
@@ -833,7 +833,7 @@ prev(Tid,Ts,Tab,Key)
 	tid ->
 	    lock_table(Tid, Ts, Tab, read),
 	    do_fixtable(Tab,Ts),
-	    New = (catch dirty_prev(Tab,Key)),
+	    New = ?CATCH(dirty_prev(Tab,Key)),
 	    stored_keys(Tab,New,Key,Ts,prev,
 			val({Tab, setorbag}));
 	_Protocol ->
@@ -965,7 +965,7 @@ foldl(Fun, Acc, Tab, LockKind) when is_function(Fun) ->
 
 foldl(ActivityId, Opaque, Fun, Acc, Tab, LockKind) ->
     {Type, Prev} = init_iteration(ActivityId, Opaque, Tab, LockKind),
-    Res = (catch do_foldl(ActivityId, Opaque, Tab, dirty_first(Tab), Fun, Acc, Type, Prev)),
+    Res = ?CATCH(do_foldl(ActivityId, Opaque, Tab, dirty_first(Tab), Fun, Acc, Type, Prev)),
     close_iteration(Res, Tab).
 
 do_foldl(A, O, Tab, '$end_of_table', Fun, RAcc, _Type, Stored) ->
@@ -1011,7 +1011,7 @@ foldr(ActivityId, Opaque, Fun, Acc, Tab, LockKind) ->
 	    true ->      %% Order doesn't matter for set and bag
 		TempPrev %% Keep the order so we can use ordsets:del_element
 	end,
-    Res = (catch do_foldr(ActivityId, Opaque, Tab, dirty_last(Tab), Fun, Acc, Type, Prev)),
+    Res = ?CATCH(do_foldr(ActivityId, Opaque, Tab, dirty_last(Tab), Fun, Acc, Type, Prev)),
     close_iteration(Res, Tab).
 
 do_foldr(A, O, Tab, '$end_of_table', Fun, RAcc, _Type, Stored) ->
@@ -1903,21 +1903,21 @@ any_table_info(Tab, _Item) ->
     abort({bad_type, Tab}).
 
 raw_table_info(Tab, Item) ->
-    case ?catch_val({Tab, storage_type}) of
-	ram_copies ->
-	    info_reply(catch ?ets_info(Tab, Item), Tab, Item);
-	disc_copies ->
-	    info_reply(catch ?ets_info(Tab, Item), Tab, Item);
-	disc_only_copies ->
-	    info_reply(catch dets:info(Tab, Item), Tab, Item);
-	unknown ->
-	    bad_info_reply(Tab, Item);
-	{'EXIT', _} ->
+    try
+	case ?ets_lookup_element(mnesia_gvar, {Tab, storage_type}, 2) of
+	    ram_copies ->
+		info_reply(?ets_info(Tab, Item), Tab, Item);
+	    disc_copies ->
+		info_reply(?ets_info(Tab, Item), Tab, Item);
+	    disc_only_copies ->
+		info_reply(dets:info(Tab, Item), Tab, Item);
+	    unknown ->
+		bad_info_reply(Tab, Item)
+	end
+    catch error:_ ->
 	    bad_info_reply(Tab, Item)
     end.
 
-info_reply({'EXIT', _Reason}, Tab, Item) ->
-    bad_info_reply(Tab, Item);
 info_reply({error, _Reason}, Tab, Item) ->
     bad_info_reply(Tab, Item);
 info_reply(Val, _Tab, _Item) ->
@@ -2061,9 +2061,8 @@ storage_count(T, {U, R, D, DO}) ->
     end.
 
 system_info(Item) ->
-    case catch system_info2(Item) of
-	{'EXIT',Error} -> abort(Error);
-	Other -> Other
+    try system_info2(Item)
+    catch _:Error -> abort(Error)
     end.
 
 system_info2(all) ->
@@ -2379,11 +2378,10 @@ del_table_index(Tab, Ix) ->
     mnesia_schema:del_table_index(Tab, Ix).
 
 transform_table(Tab, Fun, NewA) ->
-    case catch val({Tab, record_name}) of
-	{'EXIT', Reason} ->
-	    mnesia:abort(Reason);
-	OldRN ->
-	    mnesia_schema:transform_table(Tab, Fun, NewA, OldRN)
+    try val({Tab, record_name}) of
+	OldRN -> mnesia_schema:transform_table(Tab, Fun, NewA, OldRN)
+    catch exit:Reason ->
+	    mnesia:abort(Reason)
     end.
 
 transform_table(Tab, Fun, NewA, NewRN) ->
@@ -2794,7 +2792,7 @@ pre_qlc(Opts, Tab) ->
     end.
 
 post_qlc(Tab) ->
-    case catch get(mnesia_activity_state) of
+    case get(mnesia_activity_state) of
 	{_,#tid{},_} -> ok;
 	_ ->
 	    case ?catch_val({Tab, setorbag}) of
-- 
cgit v1.2.3