From a83bf960f1018217d7f3c9c8387a37722aa93fc6 Mon Sep 17 00:00:00 2001
From: Dan Gudmundsson <dgud@erlang.org>
Date: Tue, 29 Apr 2014 10:09:08 +0200
Subject: mnesia: Replace catch with try-catch

Avoids building stacktraces where it is not needed and do
not mask errors, i.e. only catch the relevant classes in each try.
---
 lib/mnesia/src/mnesia_recover.erl | 36 +++++++++++-------------------------
 1 file changed, 11 insertions(+), 25 deletions(-)

(limited to 'lib/mnesia/src/mnesia_recover.erl')

diff --git a/lib/mnesia/src/mnesia_recover.erl b/lib/mnesia/src/mnesia_recover.erl
index b6492707e2..90b3583263 100644
--- a/lib/mnesia/src/mnesia_recover.erl
+++ b/lib/mnesia/src/mnesia_recover.erl
@@ -178,11 +178,8 @@ log_decision(D) ->
 
 val(Var) ->
     case ?catch_val(Var) of
-	{'EXIT', Reason} ->
-            case mnesia_lib:other_val(Var) of
-                error -> mnesia_lib:pr_other(Var, Reason);
-                Val -> Val
-            end;
+	{'EXIT', _Reason} ->
+	    mnesia_lib:other_val(Var);
 	Value -> Value
     end.
 
@@ -373,11 +370,8 @@ log_master_nodes2([], _UseDir, IsRunning, WorstRes) ->
 get_master_node_info() ->
     Tab = mnesia_decision,
     Pat = {master_nodes, '_', '_'},
-    case catch mnesia_lib:db_match_object(ram_copies,Tab, Pat) of
-	{'EXIT', _} ->
-	    [];
-	Masters ->
-	    Masters
+    try mnesia_lib:db_match_object(ram_copies,Tab, Pat)
+    catch error:_ -> []
     end.
 
 get_master_node_tables() ->
@@ -385,9 +379,8 @@ get_master_node_tables() ->
     [Tab || {master_nodes, Tab, _Nodes} <- Masters].
 
 get_master_nodes(Tab) ->
-    case catch ?ets_lookup_element(mnesia_decision, Tab, 3) of
-	{'EXIT', _} -> [];
-	Nodes  -> Nodes
+    try ?ets_lookup_element(mnesia_decision, Tab, 3)
+    catch error:_ -> []
     end.
 
 %% Determine what has happened to the transaction
@@ -485,8 +478,6 @@ load_decision_tab() ->
     load_decision_tab(Cont, load_decision_tab),
     mnesia_log:close_decision_tab().
 
-load_decision_tab(eof, _InitBy) ->
-    ok;
 load_decision_tab(Cont, InitBy) ->
     case mnesia_log:chunk_decision_tab(Cont) of
 	{Cont2, Decisions} ->
@@ -519,8 +510,6 @@ dump_decision_log(InitBy) ->
     Cont = mnesia_log:prepare_decision_log_dump(),
     perform_dump_decision_log(Cont, InitBy).
 
-perform_dump_decision_log(eof, _InitBy) ->
-    confirm_decision_log_dump();
 perform_dump_decision_log(Cont, InitBy) when InitBy == startup ->
     case mnesia_log:chunk_decision_log(Cont) of
 	{Cont2, Decisions} ->
@@ -999,7 +988,7 @@ decision(Tid) ->
     decision(Tid, tabs()).
 
 decision(Tid, [Tab | Tabs]) ->
-    case catch ?ets_lookup(Tab, Tid) of
+    try ?ets_lookup(Tab, Tid) of
 	[D] when is_record(D, decision) ->
 	    D;
 	[C] when is_record(C, transient_decision) ->
@@ -1009,8 +998,8 @@ decision(Tid, [Tab | Tabs]) ->
 		      ram_nodes = []
 		     };
 	[] ->
-	    decision(Tid, Tabs);
-	{'EXIT', _} ->
+	    decision(Tid, Tabs)
+    catch error:_ ->
 	    %% Recently switched transient decision table
 	    decision(Tid, Tabs)
     end;
@@ -1021,11 +1010,8 @@ outcome(Tid, Default) ->
     outcome(Tid, Default, tabs()).
 
 outcome(Tid, Default, [Tab | Tabs]) ->
-    case catch ?ets_lookup_element(Tab, Tid, 3) of
-	{'EXIT', _} ->
-	    outcome(Tid, Default, Tabs);
-	Val ->
-	    Val
+    try ?ets_lookup_element(Tab, Tid, 3)
+    catch error:_ -> outcome(Tid, Default, Tabs)
     end;
 outcome(_Tid, Default, []) ->
     Default.
-- 
cgit v1.2.3