From a83bf960f1018217d7f3c9c8387a37722aa93fc6 Mon Sep 17 00:00:00 2001
From: Dan Gudmundsson <dgud@erlang.org>
Date: Tue, 29 Apr 2014 10:09:08 +0200
Subject: mnesia: Replace catch with try-catch

Avoids building stacktraces where it is not needed and do
not mask errors, i.e. only catch the relevant classes in each try.
---
 lib/mnesia/src/mnesia_schema.erl | 47 +++++++++++++++++++---------------------
 1 file changed, 22 insertions(+), 25 deletions(-)

(limited to 'lib/mnesia/src/mnesia_schema.erl')

diff --git a/lib/mnesia/src/mnesia_schema.erl b/lib/mnesia/src/mnesia_schema.erl
index 6e43052fb0..351163254b 100644
--- a/lib/mnesia/src/mnesia_schema.erl
+++ b/lib/mnesia/src/mnesia_schema.erl
@@ -151,7 +151,7 @@ exit_on_error(GoodRes) ->
 
 val(Var) ->
     case ?catch_val(Var) of
-	{'EXIT', Reason} -> mnesia_lib:other_val(Var, Reason);
+	{'EXIT', _} -> mnesia_lib:other_val(Var);
 	Value -> Value
     end.
 
@@ -2151,14 +2151,14 @@ prepare_op(_Tid, {op, transform, Fun, TabDef}, _WaitFor) ->
 	    mnesia_lib:db_fixtable(Storage, Tab, true),
             Key = mnesia_lib:db_first(Tab),
 	    Op = {op, transform, Fun, TabDef},
-            case catch transform_objs(Fun, Tab, RecName,
-				      Key, NewArity, Storage, Type, [Op]) of
-                {'EXIT', Reason} ->
-		    mnesia_lib:db_fixtable(Storage, Tab, false),
-                    exit({"Bad transform function", Tab, Fun, node(), Reason});
+            try transform_objs(Fun, Tab, RecName, Key,
+			       NewArity, Storage, Type, [Op]) of
                 Objs ->
 		    mnesia_lib:db_fixtable(Storage, Tab, false),
                     {true, Objs, mandatory}
+	    catch _:Reason ->
+		    mnesia_lib:db_fixtable(Storage, Tab, false),
+                    exit({"Bad transform function", Tab, Fun, node(), Reason})
             end
     end;
 
@@ -2342,7 +2342,7 @@ undo_prepare_commit(Tid, Commit) ->
 	    ignore;
 	Ops ->
 	    %% Catch to allow failure mnesia_controller may not be started
-	    catch mnesia_controller:release_schema_commit_lock(),
+	    ?SAFE(mnesia_controller:release_schema_commit_lock()),
 	    undo_prepare_ops(Tid, Ops)
     end,
     Commit.
@@ -2489,14 +2489,14 @@ ram_delete_table(Tab, Storage) ->
 	    %% delete possible index files and data .....
 	    %% Got to catch this since if no info has been set in the
 	    %% mnesia_gvar it will crash
-	    catch mnesia_index:del_transient(Tab, Storage),
+	    ?CATCH(mnesia_index:del_transient(Tab, Storage)),
 	    case ?catch_val({Tab, {index, snmp}}) of
 		{'EXIT', _} ->
 		    ignore;
 		Etab ->
-		    catch mnesia_snmp_hook:delete_table(Tab, Etab)
+		    ?SAFE(mnesia_snmp_hook:delete_table(Tab, Etab))
 	    end,
-	    catch ?ets_delete_table(Tab)
+	    ?SAFE(?ets_delete_table(Tab))
     end.
 
 purge_dir(Dir, KeepFiles) ->
@@ -2584,10 +2584,7 @@ info2(_, []) ->
     io:format("~n", []).
 
 get_table_properties(Tab) ->
-    case catch mnesia_lib:db_match_object(ram_copies,
-					  mnesia_gvar, {{Tab, '_'}, '_'}) of
-	{'EXIT', _} ->
-	    mnesia:abort({no_exists, Tab, all});
+    try mnesia_lib:db_match_object(ram_copies, mnesia_gvar, {{Tab, '_'}, '_'}) of
 	RawGvar ->
 	    case [{Item, Val} || {{_Tab, Item}, Val} <- RawGvar] of
 		[] ->
@@ -2598,6 +2595,8 @@ get_table_properties(Tab) ->
 		    Master = {master_nodes, mnesia:table_info(Tab, master_nodes)},
 		    lists:sort([Size, Memory, Master | Gvar])
 	    end
+    catch error:_ ->
+	    mnesia:abort({no_exists, Tab, all})
     end.
 
 %%%%%%%%%%% RESTORE %%%%%%%%%%%
@@ -2620,15 +2619,15 @@ restore(_Opaque, BadArg) ->
     {aborted, {badarg, BadArg}}.
 restore(Opaque, Args, Module) when is_list(Args), is_atom(Module) ->
     InitR = #r{opaque = Opaque, module = Module},
-    case catch lists:foldl(fun check_restore_arg/2, InitR, Args) of
+    try lists:foldl(fun check_restore_arg/2, InitR, Args) of
 	R when is_record(R, r) ->
 	    case mnesia_bup:read_schema(R#r.module, Opaque) of
 		{error, Reason} ->
 		    {aborted, Reason};
 		BupSchema ->
 		    schema_transaction(fun() -> do_restore(R, BupSchema) end)
-	    end;
-	{'EXIT', Reason} ->
+	    end
+    catch exit:Reason ->
 	    {aborted, Reason}
     end;
 restore(_Opaque, Args, Module) ->
@@ -3073,15 +3072,13 @@ do_make_merge_schema(Node, NeedsConv, RemoteCs = #cstruct{}) ->
 %% Returns a new cstruct or issues a fatal error
 merge_cstructs(Cs, RemoteCs, Force) ->
     verify_cstruct(Cs),
-    case catch do_merge_cstructs(Cs, RemoteCs, Force) of
-	{'EXIT', {aborted, _Reason}} when Force == true ->
-	    Cs;
-	{'EXIT', Reason} ->
-	    exit(Reason);
+    try do_merge_cstructs(Cs, RemoteCs, Force) of
 	MergedCs when is_record(MergedCs, cstruct) ->
-	    MergedCs;
-	Other ->
-	    throw(Other)
+	    MergedCs
+    catch exit:{aborted, _Reason} when Force == true ->
+	    Cs;
+	  exit:Reason -> exit(Reason);
+	  error:Reason -> exit(Reason)
     end.
 
 do_merge_cstructs(Cs, RemoteCs, Force) ->
-- 
cgit v1.2.3