From c9245f29ff5c5a59a58749cb3dceb2eaad4957e0 Mon Sep 17 00:00:00 2001
From: Dan Gudmundsson <dgud@erlang.org>
Date: Thu, 3 Apr 2014 13:43:38 +0200
Subject: mnesia: Improve tests

Need to re-raise the match macro if inside transaction
---
 lib/mnesia/test/mnesia_qlc_test.erl          |  2 +-
 lib/mnesia/test/mnesia_test_lib.hrl          | 35 +++++++++++++++++++++-------
 lib/mnesia/test/mnesia_trans_access_test.erl |  7 ++----
 3 files changed, 29 insertions(+), 15 deletions(-)

(limited to 'lib/mnesia/test')

diff --git a/lib/mnesia/test/mnesia_qlc_test.erl b/lib/mnesia/test/mnesia_qlc_test.erl
index 5f46840ae9..9886754710 100644
--- a/lib/mnesia/test/mnesia_qlc_test.erl
+++ b/lib/mnesia/test/mnesia_qlc_test.erl
@@ -264,7 +264,7 @@ atomic_eval(Config) ->
     
     ?match({1,[{a,{a,9},91}]}, ok(Restart,[Pid3, Cursor])),
     QC1 = ok(fun() -> qlc:cursor(Q1) end, []),
-    ?match({'EXIT', _},  qlc:next_answers(QC1)),
+    ?match({'EXIT', _},  (catch qlc:next_answers(QC1))),
     ?match({aborted,_},  ok(fun()->qlc:next_answers(QC1)end,[])),
     ?verify_mnesia(Ns, []).
 
diff --git a/lib/mnesia/test/mnesia_test_lib.hrl b/lib/mnesia/test/mnesia_test_lib.hrl
index 281634c239..94a195f01f 100644
--- a/lib/mnesia/test/mnesia_test_lib.hrl
+++ b/lib/mnesia/test/mnesia_test_lib.hrl
@@ -46,15 +46,32 @@
 
 -define(match(ExpectedRes,Expr),
 	fun() ->
-		AcTuAlReS = (catch (Expr)),
-		case AcTuAlReS of
-		    ExpectedRes ->
-			?verbose("ok, ~n Result as expected:~p~n",[AcTuAlReS]),
-			{success,AcTuAlReS};
-		    _ ->
-			?error("Not Matching Actual result was:~n ~p~n",
-			       [AcTuAlReS]),
-			{fail,AcTuAlReS}
+		try Expr of
+		    _AR_0 = ExpectedRes ->
+			?verbose("ok, ~n Result as expected:~p~n",[_AR_0]),
+			{success,_AR_0};
+		    _AR_0 ->
+			?error("Not Matching Actual result was:~n ~p~n",[_AR_0]),
+			{fail,_AR_0}
+		catch
+		    exit:{aborted, _ER_1} when
+			  element(1, _ER_1) =:= node_not_running;
+			  element(1, _ER_1) =:= bad_commit;
+			  element(1, _ER_1) =:= cyclic ->
+			%% Need to re-raise these to restart transaction
+			erlang:raise(exit, {aborted, _ER_1}, erlang:get_stacktrace());
+		    exit:_AR_1 ->
+			case fun(_AR_EXIT_) -> {'EXIT', _AR_EXIT_} end(_AR_1) of
+			    _AR_2 = ExpectedRes ->
+				?verbose("ok, ~n Result as expected:~p~n",[_AR_2]),
+				{success,_AR_2};
+			    _AR_2 ->
+				?error("Not Matching Actual result was:~n ~p~n", [_AR_2]),
+				{fail,_AR_2}
+			end;
+		    _:_AR_1 ->
+			?error("Not Matching Actual result was:~n ~p~n", [_AR_1]),
+			{fail,_AR_1}
 		end
 	end()).
 
diff --git a/lib/mnesia/test/mnesia_trans_access_test.erl b/lib/mnesia/test/mnesia_trans_access_test.erl
index 157e441b27..237984978e 100644
--- a/lib/mnesia/test/mnesia_trans_access_test.erl
+++ b/lib/mnesia/test/mnesia_trans_access_test.erl
@@ -677,7 +677,7 @@ check_res(sync_dirty, Res) when is_list(Res) ->
 check_res(ets, Res) when is_list(Res) ->
     Res;
 check_res(Type,Res) ->
-    ?match(bug,{Type,Res}).
+    ?match({bug, bug},{Type,Res}).
 
 read_op(Oid) ->
     case lists:reverse(mnesia:read(Oid)) of
@@ -1118,10 +1118,7 @@ create_live_table_index(Config, Storage) ->
     ValPos = 3,
     mnesia:dirty_write({Tab, 1, 2}),
 
-    Fun = fun() ->
-                  ?match(ok, mnesia:write({Tab, 2, 2})),
-                  ok
-          end,
+    Fun = fun() -> mnesia:write({Tab, 2, 2}) end,
     ?match({atomic, ok}, mnesia:transaction(Fun)),
     ?match({atomic, ok}, mnesia:add_table_index(Tab, ValPos)),
     IRead = fun() -> lists:sort(mnesia:index_read(Tab, 2, ValPos)) end,
-- 
cgit v1.2.3