From 827f952ce799f2051f60f0f8002d2e3908b2b5da Mon Sep 17 00:00:00 2001
From: Raimo Niskanen <raimo@erlang.org>
Date: Thu, 22 May 2014 10:06:51 +0200
Subject: Rewrite ordering functions for maintainability

---
 lib/snmp/src/agent/snmp_framework_mib.erl | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

(limited to 'lib/snmp/src/agent')

diff --git a/lib/snmp/src/agent/snmp_framework_mib.erl b/lib/snmp/src/agent/snmp_framework_mib.erl
index 6589ace949..43c91bbbc8 100644
--- a/lib/snmp/src/agent/snmp_framework_mib.erl
+++ b/lib/snmp/src/agent/snmp_framework_mib.erl
@@ -222,15 +222,9 @@ check_agent(X) ->
     error({invalid_agent_attribute, X}).
 
 %% Ordering function to sort intAgentTransportDomain first
-%% hence before intAgentIpAddress
-order_agent({Name, _}, {Name, _}) ->
-    true; %% Less than or equal
-order_agent({_, _}, {intAgentTransportDomain, _}) ->
-    false; %% Greater than
-order_agent({intAgentTransportDomain, _}, {_, _}) ->
-    true; %% Less than or equal
-order_agent({A, _}, {B, _}) ->
-    A =< B.
+%% hence before intAgentIpAddress.  Sort other entries on the key.
+order_agent(EntryA, EntryB) ->
+    snmp_conf:keyorder(1, EntryA, EntryB, [intAgentTransportDomain | sort]).
 
 
 
-- 
cgit v1.2.3