From 4b89567941ac6c00a994bde917e2d0d450dce91f Mon Sep 17 00:00:00 2001
From: Micael Karlberg <bmk@erlang.org>
Date: Thu, 14 Nov 2013 17:53:11 +0100
Subject: [snmp] Loosing log entries when converting a large Audit Trail Log

When converting an entire Audit Trail Log in a running
system its possble to have log wraps and thereby loosing
log entries.
In order to prevent this the log is now blocked during
conversion (log_to_txt or log_to_io).
---
 lib/snmp/src/misc/snmp_log.erl | 32 +++++++++++++++++++++++++++++---
 1 file changed, 29 insertions(+), 3 deletions(-)

(limited to 'lib/snmp/src/misc/snmp_log.erl')

diff --git a/lib/snmp/src/misc/snmp_log.erl b/lib/snmp/src/misc/snmp_log.erl
index a8c5df0b64..9c6cb1e077 100644
--- a/lib/snmp/src/misc/snmp_log.erl
+++ b/lib/snmp/src/misc/snmp_log.erl
@@ -1,7 +1,7 @@
 %% 
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 1997-2012. All Rights Reserved.
+%% Copyright Ericsson AB 1997-2013. All Rights Reserved.
 %%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -443,9 +443,12 @@ do_log_convert(Log, File, Converter) ->
     %% 	    "~n   Log:  ~p"
     %% 	    "~n   File: ~p"
     %% 	    "~n   disk_log:info(Log): ~p", [Log, File, disk_log:info(Log)]),
+    Verbosity  = get(verbosity), 
     {Pid, Ref} = 
 	erlang:spawn_monitor(
 	  fun() ->
+		  put(sname,     lc),
+		  put(verbosity, Verbosity), 		  
 		  Result = do_log_convert2(Log, File, Converter),
 		  exit(Result)
 	  end),
@@ -462,19 +465,35 @@ do_log_convert2(Log, File, Converter) ->
     %% First check if the caller process has already opened the
     %% log, because if we close an already open log we will cause
     %% a runtime error.
+    ?vtrace("do_log_convert2 -> entry - check if owner", []),
     case is_owner(Log) of
 	true ->
-	    Converter(Log);
+	    ?vdebug("do_log_converter2 -> owner - now convert log", []),
+	    disk_log:block(Log, true),
+	    Res = Converter(Log),
+	    disk_log:unblock(Log),
+	    Res;
 	false ->
 	    %% Not yet member of the ruling party, apply for membership...
+	    ?vtrace("do_log_converter2 -> not owner - open log", []),
 	    case log_open(Log, File) of
 		{ok, _} ->
+		    ?vdebug("do_log_convert2 -> opened - now convert log", []),
+		    disk_log:block(Log, true),
 		    Res = Converter(Log),
+		    disk_log:unblock(Log),
 		    disk_log:close(Log),
 		    Res;
 		{error, {name_already_open, _}} ->
-                    Converter(Log);
+		    ?vdebug("do_log_convert2 -> "
+			    "already opened - now convert log", []),
+		    disk_log:block(Log, true),
+                    Res = Converter(Log), 
+		    disk_log:unblock(Log),
+		    Res;
                 {error, Reason} ->
+		    ?vinfo("Failed converting log - open failed: "
+			   "~n   Reason: ~p", [Reason]),
                     {error, {Log, Reason}}
 	    end
     end.
@@ -491,6 +510,8 @@ do_log_to_file(Log, TextFile, Mibs, Start, Stop) ->
 				{ok, S} ->
 				    io:format(Fd, "~s", [S]);
 				_ ->
+				    ?vdebug("do_log_to_txt:fun -> "
+					    "format failed", []),
 				    ok
 			    end
 		    end,
@@ -499,6 +520,9 @@ do_log_to_file(Log, TextFile, Mibs, Start, Stop) ->
             file:close(Fd),
             Res;
         {error, Reason} ->
+	    ?vinfo("Failed opening output file: "
+		   "~n   TestFile: ~p"
+		   "~n   Reason:   ~p", [TextFile, Reason]),	    
             {error, {TextFile, Reason}}
     end.
 
@@ -510,6 +534,8 @@ do_log_to_io(Log, Mibs, Start, Stop) ->
 			{ok, S} ->
 			    io:format("~s", [S]);
 			_ ->
+			    ?vdebug("do_log_to_io:fun -> "
+				    "format failed", []),
 			    ok
 		    end
 	    end,
-- 
cgit v1.2.3