From 1cc828ff4e1cb93c7d909ede765314351f99f8d0 Mon Sep 17 00:00:00 2001
From: Micael Karlberg <bmk@erlang.org>
Date: Thu, 28 Mar 2019 16:28:33 +0100
Subject: [snmp|compiler|test] OTP-Mibs cleanup

Removed the last vestiges of the otp_mibs app from the
compiler test suite (was still trying to use MIBs from
otp_mibs).
---
 lib/snmp/test/snmp_compiler_test.erl | 27 ++++++++++++++++-----------
 1 file changed, 16 insertions(+), 11 deletions(-)

(limited to 'lib/snmp')

diff --git a/lib/snmp/test/snmp_compiler_test.erl b/lib/snmp/test/snmp_compiler_test.erl
index 2e48d5134d..a28f925a22 100644
--- a/lib/snmp/test/snmp_compiler_test.erl
+++ b/lib/snmp/test/snmp_compiler_test.erl
@@ -226,10 +226,8 @@ agent_capabilities(Config) when is_list(Config) ->
     put(tname,agent_capabilities),
     p("starting with Config: ~p~n", [Config]),
 
-    SnmpPrivDir    = code:priv_dir(snmp),
+    SnmpPrivDir    = which_priv_dir(snmp),
     SnmpMibsDir    = join(SnmpPrivDir, "mibs"), 
-    OtpMibsPrivDir = code:priv_dir(otp_mibs),
-    OtpMibsMibsDir = join(OtpMibsPrivDir, "mibs"), 
     Dir   = ?config(mib_dir, Config),
     AcMib = join(Dir,"AC-TEST-MIB.mib"),
     ?line {ok, MibFile1} = snmpc:compile(AcMib, [options,
@@ -269,22 +267,20 @@ module_compliance(Config) when is_list(Config) ->
     put(tname,module_compliance),
     p("starting with Config: ~p~n", [Config]),
 
-    SnmpPrivDir    = code:priv_dir(snmp),
-    SnmpMibsDir    = join(SnmpPrivDir, "mibs"), 
-    OtpMibsPrivDir = code:priv_dir(otp_mibs),
-    OtpMibsMibsDir = join(OtpMibsPrivDir, "mibs"), 
-    Dir   = ?config(mib_dir, Config),
-    AcMib = join(Dir,"MC-TEST-MIB.mib"),
+    SnmpPrivDir = which_priv_dir(snmp),
+    SnmpMibsDir = join(SnmpPrivDir, "mibs"), 
+    Dir         = ?config(mib_dir, Config),
+    AcMib       = join(Dir,"MC-TEST-MIB.mib"),
     ?line {ok, MibFile1} = snmpc:compile(AcMib, [options,
 						 version,
-						 {i,           [SnmpMibsDir, OtpMibsMibsDir]}, 
+						 {i,           [SnmpMibsDir]}, 
 						 {outdir,      Dir}, 
 						 {verbosity,   trace}]),
     ?line {ok, Mib1} = snmp_misc:read_mib(MibFile1), 
     ?line {ok, MibFile2} = snmpc:compile(AcMib, [options,
 						 version,
 						 module_compliance,
-						 {i,           [SnmpMibsDir, OtpMibsMibsDir]}, 
+						 {i,           [SnmpMibsDir]}, 
 						 {outdir,      Dir}, 
 						 {verbosity,   trace}]),
     ?line {ok, Mib2} = snmp_misc:read_mib(MibFile2), 
@@ -731,6 +727,15 @@ check_desc(Desc1, Desc2) ->
     exit({'description not equal', Desc1, Desc2}).
 
 
+which_priv_dir(App) ->
+    case code:priv_dir(App) of
+        Dir when is_list(Dir) ->
+            Dir;
+        {error, Reason} ->
+            exit({App, priv_dir_not_found, Reason})
+    end.
+    
+
 %% join(Comp) ->
 %%     filename:join(Comp).
 
-- 
cgit v1.2.3