From 622a93103493993a4c8755f116693a9f625d2ad0 Mon Sep 17 00:00:00 2001
From: Ingela Anderton Andin <ingela@erlang.org>
Date: Mon, 5 Sep 2016 16:05:07 +0200
Subject: snmp: Use ipv6 common test configuration check

The test for ipv6 could return false positives which resulted in failing
test cases due lack of full ipv6 support.It could be nice with a working
run-time check but this will do for now.
---
 lib/snmp/test/snmp_agent_test.erl       | 26 +++++++++++++-------------
 lib/snmp/test/snmp_manager_test.erl     | 26 +++++++++++++-------------
 lib/snmp/test/snmp_to_snmpnet_SUITE.erl | 10 +++++-----
 3 files changed, 31 insertions(+), 31 deletions(-)

(limited to 'lib/snmp')

diff --git a/lib/snmp/test/snmp_agent_test.erl b/lib/snmp/test/snmp_agent_test.erl
index 8ae495bb1b..3c1a6f2afd 100644
--- a/lib/snmp/test/snmp_agent_test.erl
+++ b/lib/snmp/test/snmp_agent_test.erl
@@ -647,22 +647,22 @@ init_per_group(GroupName, Config) ->
     snmp_test_lib:init_group_top_dir(GroupName, Config).
 
 init_per_group_ipv6(GroupName, Config, Init) ->
+    {ok, Hostname0} = inet:gethostname(),
     case ct:require(ipv6_hosts) of
 	ok ->
-	    case gen_udp:open(0, [inet6]) of
-		{ok, S} ->
-		    ok = gen_udp:close(S),
-		    Init(
-		      snmp_test_lib:init_group_top_dir(
-			GroupName,
-			[{ipfamily, inet6},
-			 {ip, ?LOCALHOST(inet6)}
-			 | lists:keydelete(ip, 1, Config)]));
-		{error, _} ->
-		    {skip, "Host seems to not support IPv6"}
-	    end;
+	  case lists:member(list_to_atom(Hostname0), ct:get_config(ipv6_hosts)) of
+	      true ->
+		  Init(
+		    snmp_test_lib:init_group_top_dir(
+		      GroupName,
+		      [{ipfamily, inet6},
+		       {ip, ?LOCALHOST(inet6)}
+		       | lists:keydelete(ip, 1, Config)]));
+	      false ->
+		  {skip, "Host does not support IPV6"}
+	  end;
 	_ ->
-	    {skip, "Host does not support IPV6"}
+	    {skip, "Test config ipv6_hosts is missing"}
     end.
 
 end_per_group(all_tcs, Config) ->
diff --git a/lib/snmp/test/snmp_manager_test.erl b/lib/snmp/test/snmp_manager_test.erl
index d17882e765..71f4017d8b 100644
--- a/lib/snmp/test/snmp_manager_test.erl
+++ b/lib/snmp/test/snmp_manager_test.erl
@@ -583,38 +583,38 @@ init_per_group(event_tests_mt = GroupName, Config) ->
       GroupName, 
       [{manager_net_if_module, snmpm_net_if_mt} | Config]);
 init_per_group(ipv6_mt = GroupName, Config) ->
+    {ok, Hostname0} = inet:gethostname(),
     case ct:require(ipv6_hosts) of
 	ok ->
-	    case gen_udp:open(0, [inet6]) of
-		{ok, S} ->
-		    ok = gen_udp:close(S),
+	    case lists:member(list_to_atom(Hostname0), ct:get_config(ipv6_hosts)) of
+		true ->
 		    ipv6_init(
 		      snmp_test_lib:init_group_top_dir(
 			GroupName,
 			[{manager_net_if_module, snmpm_net_if_mt}
 			 | Config]));
-		{error, _} ->
-		    {skip, "Host seems to not support IPv6"}
+		false ->
+		    {skip, "Host does not support IPv6"}
 	    end;
 	_ ->
-	    {skip, "Host does not support IPV6"}
+	    {skip, "Test config ipv6_hosts is missing"}
     end;
 init_per_group(ipv6 = GroupName, Config) -> 
+    {ok, Hostname0} = inet:gethostname(),
     case ct:require(ipv6_hosts) of
 	ok ->
-	    case gen_udp:open(0, [inet6]) of
-		{ok, S} ->
-		    ok = gen_udp:close(S),
+	    case lists:member(list_to_atom(Hostname0), ct:get_config(ipv6_hosts)) of
+		true ->
 		    ipv6_init(snmp_test_lib:init_group_top_dir(GroupName, Config));
-		{error, _} ->
-		    {skip, "Host seems to not support IPv6"}
+		false ->
+		    {skip, "Host does not support IPv6"}
 	    end;
 	_ ->
-	    {skip, "Host does not support IPV6"}
+	    {skip, "Test config ipv6_hosts is missing"}
     end;
 init_per_group(GroupName, Config) ->
     snmp_test_lib:init_group_top_dir(GroupName, Config).
-   
+
 end_per_group(_GroupName, Config) ->
     %% Do we really need to do this?
     lists:keydelete(snmp_group_top_dir, 1, Config).
diff --git a/lib/snmp/test/snmp_to_snmpnet_SUITE.erl b/lib/snmp/test/snmp_to_snmpnet_SUITE.erl
index ac9e37bc8b..24c14d86ea 100644
--- a/lib/snmp/test/snmp_to_snmpnet_SUITE.erl
+++ b/lib/snmp/test/snmp_to_snmpnet_SUITE.erl
@@ -121,14 +121,14 @@ init_per_group(_, Config) ->
     Config.
 
 init_per_group_ipv6(Families, Config) ->
+    {ok, Hostname0} = inet:gethostname(),
     case ct:require(ipv6_hosts) of
 	ok ->
-	    case gen_udp:open(0, [inet6]) of
-		{ok, S} ->
-		    ok = gen_udp:close(S),
+	    case lists:member(list_to_atom(Hostname0), ct:get_config(ipv6_hosts)) of
+		true ->
 		    init_per_group_ip(Families, Config);
-		{error, _} ->
-		    {skip, "Host seems to not support IPv6"}
+		false ->
+		    {skip, "Host does not support IPv6"}
 	    end;
 	_ ->
 	    {skip, "Test config ipv6_hosts is missing"}
-- 
cgit v1.2.3