From 20b3aa4dabab14ea1a653fb9f88c842edd0e2a69 Mon Sep 17 00:00:00 2001
From: Ingela Anderton Andin <ingela@erlang.org>
Date: Wed, 8 Jun 2016 14:29:46 +0200
Subject: ssl: Propagate error so that public_key crl validation process
 continues correctly and determines what should happen.

---
 lib/ssl/src/ssl_crl.erl | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

(limited to 'lib/ssl/src/ssl_crl.erl')

diff --git a/lib/ssl/src/ssl_crl.erl b/lib/ssl/src/ssl_crl.erl
index faf5007b16..d9f21e04ac 100644
--- a/lib/ssl/src/ssl_crl.erl
+++ b/lib/ssl/src/ssl_crl.erl
@@ -39,13 +39,12 @@ trusted_cert_and_path(CRL, {SerialNumber, Issuer},{Db, DbRef} = DbHandle) ->
     end;
 
 trusted_cert_and_path(CRL, issuer_not_found, {Db, DbRef} = DbHandle) -> 
-    try find_issuer(CRL, DbHandle) of
-	OtpCert ->
+    case find_issuer(CRL, DbHandle) of
+	{ok, OtpCert} ->
 	    {ok, Root, Chain} = ssl_certificate:certificate_chain(OtpCert, Db, DbRef),
-	    {ok, Root, lists:reverse(Chain)}
-    catch
-	throw:_ ->
-	    {error, issuer_not_found}
+	    {ok, Root, lists:reverse(Chain)};
+	{error, issuer_not_found} ->
+	    {ok, unknown_crl_ca, []}
     end.
 
 find_issuer(CRL, {Db,_}) ->
@@ -61,11 +60,10 @@ find_issuer(CRL, {Db,_}) ->
 	issuer_not_found ->
 	    {error, issuer_not_found}
     catch 
-	{ok, IssuerCert}  ->
-	    IssuerCert
+	{ok, _} = Result ->
+	    Result
     end.
 
-
 verify_crl_issuer(CRL, ErlCertCandidate, Issuer, NotIssuer) ->
     TBSCert =  ErlCertCandidate#'OTPCertificate'.tbsCertificate,
     case public_key:pkix_normalize_name(TBSCert#'OTPTBSCertificate'.subject) of
-- 
cgit v1.2.3