From e56167dd6ca8d37d26ea7f19933691a3bda41113 Mon Sep 17 00:00:00 2001
From: Ingela Anderton Andin <ingela@erlang.org>
Date: Mon, 21 Jan 2013 10:54:53 +0100
Subject: ssl: Enhance error handling

Remove filter mechanisms that made error messages backwards compatible
with old ssl but hid information about what actually happened.

This does not break the documented API however other reason
terms may be returned, so code that matches on the reason part of
{error, Reason} may fail.
---
 lib/ssl/test/ssl_test_lib.erl | 77 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 77 insertions(+)

(limited to 'lib/ssl/test/ssl_test_lib.erl')

diff --git a/lib/ssl/test/ssl_test_lib.erl b/lib/ssl/test/ssl_test_lib.erl
index 76b302b1cb..8d96a70a6e 100644
--- a/lib/ssl/test/ssl_test_lib.erl
+++ b/lib/ssl/test/ssl_test_lib.erl
@@ -203,6 +203,67 @@ close(Pid) ->
 	    ct:print("Pid: ~p down due to:~p ~n", [Pid, Reason])
     end.
 
+
+check_result(Server, {error, SReason} = ServerMsg, Client,  {error, closed} = ClientMsg) -> 
+    receive 
+	{Server, {error, {SReason, _}}} -> 
+	    receive 
+		{Client, ClientMsg} ->
+		    ok;
+		Unexpected ->
+		    Reason = {{expected, {Client, ClientMsg}}, 
+			      {got, Unexpected}},
+		    ct:fail(Reason)
+	    end;
+	{Client, ClientMsg} -> 
+	    receive 
+		{Server, {error, {SReason, _}}} ->
+		    ok;
+		Unexpected ->
+		    Reason = {{expected, {Server,{error, {SReason, 'term()'}}}, 
+			      {got, Unexpected}}},
+		    ct:fail(Reason)
+	    end;
+	{Port, {data,Debug}} when is_port(Port) ->
+	    io:format("openssl ~s~n",[Debug]),
+	    check_result(Server, ServerMsg, Client, ClientMsg);
+
+	Unexpected ->
+	    Reason = {{expected, {Client, ClientMsg}},
+		      {expected, {Server, {error, {SReason, 'term()'}}}, {got, Unexpected}}},
+	    ct:fail(Reason)
+    end;
+
+check_result(Server, {error, closed} = ServerMsg, Client,  {error, CReson} = ClientMsg) -> 
+    receive 
+	{Server, ServerMsg} -> 
+	    receive 
+		{Client, {error, {CReson, _}}} ->
+		    ok;
+		Unexpected ->
+		    Reason = {{expected, {Client, {error, {CReson, 'term()'}}}, 
+			      {got, Unexpected}}},
+		    ct:fail(Reason)
+	    end;
+	{Client, {error, {CReson, _}}} -> 
+	    receive 
+		{Server, ServerMsg} ->
+		    ok;
+		Unexpected ->
+		    Reason = {{expected, {Server, ServerMsg}}, 
+			      {got, Unexpected}},
+		    ct:fail(Reason)
+	    end;
+	{Port, {data,Debug}} when is_port(Port) ->
+	    io:format("openssl ~s~n",[Debug]),
+	    check_result(Server, ServerMsg, Client, ClientMsg);
+
+	Unexpected ->
+	    Reason = {{expected, {Client, {error, {CReson, 'term()'}}},
+		      {expected, {Server, ServerMsg}}, {got, Unexpected}}},
+	    ct:fail(Reason)
+    end;
+
 check_result(Server, ServerMsg, Client, ClientMsg) -> 
     receive 
 	{Server, ServerMsg} -> 
@@ -233,6 +294,22 @@ check_result(Server, ServerMsg, Client, ClientMsg) ->
 	    ct:fail(Reason)
     end.
 
+check_result(Pid, {error, Reason} = Err) when Reason == ecertfile;
+					      Reason == ecacertfile;
+					      Reason == ekeyfile;
+					      Reason == edhfile ->
+    receive 
+	{Pid, {error, {Reason, Str}}} when is_list(Str) -> 
+	    ok;
+	{Port, {data,Debug}} when is_port(Port) ->
+	    io:format("openssl ~s~n",[Debug]),
+	    check_result(Pid, Err);
+	Unexpected ->
+	    Reason = {{expected, {Pid, {error, {Reason, "'appropriate error string'"}}}}, 
+		      {got, Unexpected}},
+	    ct:fail(Reason)
+    end;
+
 check_result(Pid, Msg) -> 
     receive 
 	{Pid, Msg} -> 
-- 
cgit v1.2.3