From 9bca15422cc76e2145e30b822ccc3599abec278a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Tue, 14 Apr 2015 07:42:21 +0200
Subject: orddict: Eliminate unnecessary consing in store/3 and others

As a minor optimization, eliminate unnecessary cons operations
in store/3, append/3, append_list/3, update/4, and update_counter/3.
---
 lib/stdlib/src/orddict.erl | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

(limited to 'lib/stdlib')

diff --git a/lib/stdlib/src/orddict.erl b/lib/stdlib/src/orddict.erl
index c98d78b34d..af5d917840 100644
--- a/lib/stdlib/src/orddict.erl
+++ b/lib/stdlib/src/orddict.erl
@@ -115,8 +115,8 @@ erase(_, []) -> [].
       Orddict1 :: orddict(),
       Orddict2 :: orddict().
 
-store(Key, New, [{K,_}=E|Dict]) when Key < K ->
-    [{Key,New},E|Dict];
+store(Key, New, [{K,_}|_]=Dict) when Key < K ->
+    [{Key,New}|Dict];
 store(Key, New, [{K,_}=E|Dict]) when Key > K ->
     [E|store(Key, New, Dict)];
 store(Key, New, [{_K,_Old}|Dict]) ->		%Key == K
@@ -129,8 +129,8 @@ store(Key, New, []) -> [{Key,New}].
       Orddict1 :: orddict(),
       Orddict2 :: orddict().
 
-append(Key, New, [{K,_}=E|Dict]) when Key < K ->
-    [{Key,[New]},E|Dict];
+append(Key, New, [{K,_}|_]=Dict) when Key < K ->
+    [{Key,[New]}|Dict];
 append(Key, New, [{K,_}=E|Dict]) when Key > K ->
     [E|append(Key, New, Dict)];
 append(Key, New, [{_K,Old}|Dict]) ->		%Key == K
@@ -143,8 +143,8 @@ append(Key, New, []) -> [{Key,[New]}].
       Orddict1 :: orddict(),
       Orddict2 :: orddict().
 
-append_list(Key, NewList, [{K,_}=E|Dict]) when Key < K ->
-    [{Key,NewList},E|Dict];
+append_list(Key, NewList, [{K,_}|_]=Dict) when Key < K ->
+    [{Key,NewList}|Dict];
 append_list(Key, NewList, [{K,_}=E|Dict]) when Key > K ->
     [E|append_list(Key, NewList, Dict)];
 append_list(Key, NewList, [{_K,Old}|Dict]) ->		%Key == K
@@ -170,8 +170,8 @@ update(Key, Fun, [{K,Val}|Dict]) when Key == K ->
       Orddict1 :: orddict(),
       Orddict2 :: orddict().
 
-update(Key, _, Init, [{K,_}=E|Dict]) when Key < K ->
-    [{Key,Init},E|Dict];
+update(Key, _, Init, [{K,_}|_]=Dict) when Key < K ->
+    [{Key,Init}|Dict];
 update(Key, Fun, Init, [{K,_}=E|Dict]) when Key > K ->
     [E|update(Key, Fun, Init, Dict)];
 update(Key, Fun, _Init, [{_K,Val}|Dict]) ->		%Key == K
@@ -184,8 +184,8 @@ update(Key, _, Init, []) -> [{Key,Init}].
       Orddict1 :: orddict(),
       Orddict2 :: orddict().
 
-update_counter(Key, Incr, [{K,_}=E|Dict]) when Key < K ->
-    [{Key,Incr},E|Dict];
+update_counter(Key, Incr, [{K,_}|_]=Dict) when Key < K ->
+    [{Key,Incr}|Dict];
 update_counter(Key, Incr, [{K,_}=E|Dict]) when Key > K ->
     [E|update_counter(Key, Incr, Dict)];
 update_counter(Key, Incr, [{_K,Val}|Dict]) ->		%Key == K
-- 
cgit v1.2.3


From 68fdf06841859afc4de3ccdc26fac7b78e8b47db Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Thu, 16 Apr 2015 13:43:29 +0200
Subject: erl_expand_records: Simplify handling of call_ext instructions

The erl_expand_records module have inherited code from sys_pre_expand.
We can simplify the code for handling the call_ext instruction to
make the code clearer and a smidge faster.
---
 lib/stdlib/src/erl_expand_records.erl | 25 ++++++-------------------
 1 file changed, 6 insertions(+), 19 deletions(-)

(limited to 'lib/stdlib')

diff --git a/lib/stdlib/src/erl_expand_records.erl b/lib/stdlib/src/erl_expand_records.erl
index 64a00acd88..dc74d611a3 100644
--- a/lib/stdlib/src/erl_expand_records.erl
+++ b/lib/stdlib/src/erl_expand_records.erl
@@ -384,21 +384,11 @@ expr({call,Line,{tuple,_,[{atom,_,erlang},{atom,_,is_record}]},
 expr({call,Line,{atom,_La,N}=Atom,As0}, St0) ->
     {As,St1} = expr_list(As0, St0),
     Ar = length(As),
-    case erl_internal:bif(N, Ar) of
-        true ->
-            {{call,Line,Atom,As},St1};
-        false ->
-            case imported(N, Ar, St1) of
-                {yes,_Mod} ->
-                    {{call,Line,Atom,As},St1};
-                no ->
-                    case {N,Ar} of
-                        {record_info,2} ->
-                            record_info_call(Line, As, St1);
-                        _ ->
-                            {{call,Line,Atom,As},St1}
-                    end
-            end
+    case {N,Ar} =:= {record_info,2} andalso not imported(N, Ar, St1) of
+	true ->
+	    record_info_call(Line, As, St1);
+	false ->
+	    {{call,Line,Atom,As},St1}
     end;
 expr({call,Line,{remote,Lr,M,F},As0}, St0) ->
     {[M1,F1 | As1],St1} = expr_list([M,F | As0], St0),
@@ -832,10 +822,7 @@ add_imports(Mod, [F | Fs], Is) ->
 add_imports(_, [], Is) -> Is.
 
 imported(F, A, St) ->
-    case orddict:find({F,A}, St#exprec.imports) of
-        {ok,Mod} -> {yes,Mod};
-        error -> no
-    end.
+    orddict:is_key({F,A}, St#exprec.imports).
 
 %%%
 %%% Replace is_record/3 in guards with matching if possible.
-- 
cgit v1.2.3