From 3339aabf37dc65fd3fa66482764fc9c533d65933 Mon Sep 17 00:00:00 2001
From: Dan Gudmundsson <dgud@erlang.org>
Date: Wed, 6 May 2015 13:33:33 +0200
Subject: mnesia: dirty error messages did not behave as documented

The docs express that exit({aborted, Reason}) are called when
an error occur.
---
 lib/mnesia/src/mnesia.erl                     | 10 +++-------
 lib/mnesia/src/mnesia_lib.erl                 |  2 +-
 lib/mnesia/test/mnesia_evil_coverage_test.erl |  6 +++---
 3 files changed, 7 insertions(+), 11 deletions(-)

(limited to 'lib')

diff --git a/lib/mnesia/src/mnesia.erl b/lib/mnesia/src/mnesia.erl
index f501a4485b..b9c2fd915c 100644
--- a/lib/mnesia/src/mnesia.erl
+++ b/lib/mnesia/src/mnesia.erl
@@ -306,6 +306,8 @@ ms() ->
 
 -spec abort(_) -> no_return().
 
+abort(Reason = {aborted, _}) ->
+    exit(Reason);
 abort(Reason) ->
     exit({aborted, Reason}).
 
@@ -1626,13 +1628,7 @@ dirty_read(Oid) ->
 
 dirty_read(Tab, Key)
   when is_atom(Tab), Tab /= schema ->
-%%    case catch ?ets_lookup(Tab, Key) of
-%%        {'EXIT', _} ->
-            %% Bad luck, we have to perform a real lookup
-            dirty_rpc(Tab, mnesia_lib, db_get, [Tab, Key]);
-%%        Val ->
-%%            Val
-%%    end;
+    dirty_rpc(Tab, mnesia_lib, db_get, [Tab, Key]);
 dirty_read(Tab, _Key) ->
     abort({bad_type, Tab}).
 
diff --git a/lib/mnesia/src/mnesia_lib.erl b/lib/mnesia/src/mnesia_lib.erl
index 7bd207f816..fc7362a31d 100644
--- a/lib/mnesia/src/mnesia_lib.erl
+++ b/lib/mnesia/src/mnesia_lib.erl
@@ -411,7 +411,7 @@ pr_other(Var) ->
     verbose("~p (~p) val(mnesia_gvar, ~w) -> ~p ~n",
 	    [self(), process_info(self(), registered_name),
 	     Var, Why]),
-    exit(Why).
+    mnesia:abort(Why).
 
 %% Some functions for list valued variables
 add(Var, Val) ->
diff --git a/lib/mnesia/test/mnesia_evil_coverage_test.erl b/lib/mnesia/test/mnesia_evil_coverage_test.erl
index 2d1623b6ca..430c1f1d84 100644
--- a/lib/mnesia/test/mnesia_evil_coverage_test.erl
+++ b/lib/mnesia/test/mnesia_evil_coverage_test.erl
@@ -1338,11 +1338,11 @@ user_properties(Config) when is_list(Config) ->
     ?match([], mnesia:table_info(Tab2, user_properties)),
     ?match([], mnesia:table_info(Tab3, user_properties)),
 
-    ?match({'EXIT', {no_exists, {Tab1, user_property, PropKey}}},
+    ?match({'EXIT', {aborted, {no_exists, {Tab1, user_property, PropKey}}}},
 	   mnesia:read_table_property(Tab1, PropKey)),
-    ?match({'EXIT', {no_exists, {Tab2, user_property, PropKey}}},
+    ?match({'EXIT', {aborted, {no_exists, {Tab2, user_property, PropKey}}}},
 	   mnesia:read_table_property(Tab2, PropKey)),
-    ?match({'EXIT', {no_exists, {Tab3, user_property, PropKey}}},
+    ?match({'EXIT', {aborted, {no_exists, {Tab3, user_property, PropKey}}}},
 	   mnesia:read_table_property(Tab3, PropKey)),
 
     ?match({atomic, ok}, mnesia:write_table_property(Tab1, Prop)),
-- 
cgit v1.2.3