From 827dc3c7e13d4ce21315f441c4400fb575f41c20 Mon Sep 17 00:00:00 2001
From: Ingela Anderton Andin <ingela@erlang.org>
Date: Mon, 29 Nov 2010 14:54:08 +0100
Subject: Fixed broken links in the documentation and dialyzer warnings

---
 lib/public_key/src/pubkey_cert.erl |  2 +-
 lib/public_key/src/public_key.erl  | 21 +++++++++++++--------
 lib/ssl/doc/src/ssl.xml            | 12 ++++++------
 3 files changed, 20 insertions(+), 15 deletions(-)

(limited to 'lib')

diff --git a/lib/public_key/src/pubkey_cert.erl b/lib/public_key/src/pubkey_cert.erl
index c8953c6818..fadb993ed9 100644
--- a/lib/public_key/src/pubkey_cert.erl
+++ b/lib/public_key/src/pubkey_cert.erl
@@ -164,7 +164,7 @@ validate_signature(OtpCert, DerCert, Key, KeyParams,
 	    verify_fun(OtpCert, {bad_cert, invalid_signature}, UserState, VerifyFun)
     end.
 %%--------------------------------------------------------------------
--spec validate_names(#'OTPCertificate'{}, list(), list(),
+-spec validate_names(#'OTPCertificate'{}, no_constraints | list(), list(),
 		     term(), term(), fun())-> term().
 %%
 %% Description: Validate Subject Alternative Name.
diff --git a/lib/public_key/src/public_key.erl b/lib/public_key/src/public_key.erl
index 095a6ff0e0..64496d6f15 100644
--- a/lib/public_key/src/public_key.erl
+++ b/lib/public_key/src/public_key.erl
@@ -213,10 +213,13 @@ decrypt_private(CipherText,
 				crypto:mpint(D)], Padding).
 
 %%--------------------------------------------------------------------
--spec decrypt_public(CipherText :: binary(), rsa_public_key()) -> 
+-spec decrypt_public(CipherText :: binary(), rsa_public_key() | rsa_private_key()) ->
 			    PlainText :: binary().
--spec decrypt_public(CipherText :: binary(), rsa_public_key(), 
+-spec decrypt_public(CipherText :: binary(), rsa_public_key() | rsa_private_key(),
 		     public_crypt_options()) -> PlainText :: binary().
+%% NOTE: The rsa_private_key() is not part of the documented API it is
+%% here for testing purposes, in a real situation this is not a relevant
+%% thing to do.
 %%
 %% Description: Public key decryption using the public key.
 %%--------------------------------------------------------------------
@@ -232,10 +235,14 @@ decrypt_public(CipherText,#'RSAPrivateKey'{modulus = N, publicExponent = E},
     decrypt_public(CipherText, N,E, Options).
 
 %%--------------------------------------------------------------------
--spec encrypt_public(PlainText :: binary(), rsa_public_key()) ->  
+-spec encrypt_public(PlainText :: binary(), rsa_public_key() | rsa_private_key()) ->
 			    CipherText :: binary().
--spec encrypt_public(PlainText :: binary(), rsa_public_key(), 
+-spec encrypt_public(PlainText :: binary(), rsa_public_key() | rsa_private_key(),
 		     public_crypt_options()) ->  CipherText :: binary().
+
+%% NOTE: The rsa_private_key() is not part of the documented API it is
+%% here for testing purposes, in a real situation this is not a relevant
+%% thing to do.
 %%
 %% Description: Public key encryption using the public key.
 %%--------------------------------------------------------------------
@@ -571,11 +578,9 @@ validate(DerCert, #path_validation_state{working_issuer_name = Issuer,
 
     pubkey_cert:prepare_for_next_cert(OtpCert, ValidationState).
 
-sized_binary(Binary) when is_binary(Binary) ->
+sized_binary(Binary) ->
     Size = size(Binary),
-    <<?UINT32(Size), Binary/binary>>;
-sized_binary(List) ->
-    sized_binary(list_to_binary(List)).
+    <<?UINT32(Size), Binary/binary>>.
 
 %%--------------------------------------------------------------------
 %%% Deprecated functions
diff --git a/lib/ssl/doc/src/ssl.xml b/lib/ssl/doc/src/ssl.xml
index 511f1e0bb2..ec272379bb 100644
--- a/lib/ssl/doc/src/ssl.xml
+++ b/lib/ssl/doc/src/ssl.xml
@@ -218,12 +218,12 @@ fun(OtpCert :: #'OTPCertificate'{}, Event :: {bad_cert, Reason :: atom()} |
 	application is encountered. Additionally it will be called
 	when a certificate is considered valid by the path validation
 	to allow access to each certificate in the path to the user
-	application. Note that the it will differentiate between
-	the peer certificate and CA certificates by using valid_peer
-	or valid as the second argument to the verify fun.
-	See
-	<seealso marker="public_key:application">public_key(3)</seealso>
-	for definition of #'OTPCertificate'{} and #'Extension'{}.</p>
+	application. Note that the it will differentiate between the
+	peer certificate and CA certificates by using valid_peer or
+	valid as the second argument to the verify fun.  See <seealso
+	marker="public_key:cert_records">the public_key User's
+	Guide</seealso> for definition of #'OTPCertificate'{} and
+	#'Extension'{}.</p>
 
 	<p>If the verify callback fun returns {fail, Reason}, the
 	verification process is immediately stopped and an alert is
-- 
cgit v1.2.3