From d53cb8e4f366669714c8c68a0fb481e8eaf849c9 Mon Sep 17 00:00:00 2001
From: Hans Nilsson <hans@erlang.org>
Date: Mon, 22 Oct 2018 10:12:47 +0200
Subject: crypto: Disable engine tests on Darwin and Windows Does not work.

---
 lib/crypto/test/engine_SUITE.erl | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

(limited to 'lib')

diff --git a/lib/crypto/test/engine_SUITE.erl b/lib/crypto/test/engine_SUITE.erl
index b083b30d70..0427923941 100644
--- a/lib/crypto/test/engine_SUITE.erl
+++ b/lib/crypto/test/engine_SUITE.erl
@@ -75,11 +75,18 @@ groups() ->
 
 
 init_per_suite(Config) ->
-    case crypto:info_lib() of
-        [{_,_, <<"OpenSSL 1.0.1s-freebsd  1 Mar 2016">>}] ->
+    case {os:type(), crypto:info_lib()} of
+        {_, [{_,_, <<"OpenSSL 1.0.1s-freebsd  1 Mar 2016">>}]} ->
             {skip, "Problem with engine on OpenSSL 1.0.1s-freebsd"};
-        Res ->
-            ct:log("crypto:info_lib() -> ~p\n", [Res]),
+
+        {{unix,darwin}, _} ->
+            {skip, "Engine unsupported on Darwin"};
+        
+        {{win32,_}, _} ->
+            {skip, "Engine unsupported on Windows"};
+        
+        {OS, Res} ->
+            ct:log("crypto:info_lib() -> ~p\nos:type() -> ~p", [Res,OS]),
             try crypto:start() of
                 ok ->
                     Config;
-- 
cgit v1.2.3


From 93550a678b6459b6490b1a2341207021bd4e6cb2 Mon Sep 17 00:00:00 2001
From: Hans Nilsson <hans@erlang.org>
Date: Mon, 22 Oct 2018 10:50:00 +0200
Subject: crypto: Fix tests failing if more than one test engine available This
 could happen in an Valgrind run:

=== Reason: no case clause matching ["otp_test_engine.so",
                                          "otp_test_engine.valgrind.so"]
  in function  crypto:check_otp_test_engine/1 (crypto.erl, line 2026)
  in call from engine_SUITE:engine_load_all_methods/1 (engine_SUITE.erl, line 154)
---
 lib/crypto/src/crypto.erl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'lib')

diff --git a/lib/crypto/src/crypto.erl b/lib/crypto/src/crypto.erl
index 2db73c4af0..c2ab88417e 100644
--- a/lib/crypto/src/crypto.erl
+++ b/lib/crypto/src/crypto.erl
@@ -2026,7 +2026,7 @@ check_otp_test_engine(LibDir) ->
     case filelib:wildcard("otp_test_engine*", LibDir) of
         [] ->
             {error, notexist};
-        [LibName] ->
+        [LibName|_] ->                          % In case of Valgrind there could be more than one
             LibPath = filename:join(LibDir,LibName),
             case filelib:is_file(LibPath) of
                 true ->
-- 
cgit v1.2.3