From dbdc87f8308a4f5c4cfa5e257923970f9a3baa83 Mon Sep 17 00:00:00 2001
From: Ingela Anderton Andin <ingela@erlang.org>
Date: Thu, 21 Aug 2014 14:50:14 +0200
Subject: inets: Enable ipv6 tests for httpd

---
 lib/inets/test/httpd_SUITE.erl    | 27 ++++++++++++++++++++++-----
 lib/inets/test/httpd_test_lib.erl | 11 +----------
 2 files changed, 23 insertions(+), 15 deletions(-)

(limited to 'lib')

diff --git a/lib/inets/test/httpd_SUITE.erl b/lib/inets/test/httpd_SUITE.erl
index de47760e6e..4010597657 100644
--- a/lib/inets/test/httpd_SUITE.erl
+++ b/lib/inets/test/httpd_SUITE.erl
@@ -148,8 +148,24 @@ init_per_suite(Config) ->
     inets_test_lib:del_dirs(ServerRoot),
     DocRoot = filename:join(ServerRoot, "htdocs"),
     setup_server_dirs(ServerRoot, DocRoot, DataDir),
+    {ok, Hostname0} = inet:gethostname(),
+    Inet = 
+	case (catch ct:get_config(ipv6_hosts)) of
+	    undefined ->
+		inet;
+	    Hosts when is_list(Hosts) ->
+		case lists:member(list_to_atom(Hostname0), Hosts) of
+		    true ->
+			inet6;
+		    false ->
+			inet
+		end;
+	    _ ->
+		inet
+	end,
     [{server_root, ServerRoot}, 
      {doc_root, DocRoot},
+     {ipfamily, Inet},
      {node,             node()},
      {host,             inets_test_lib:hostname()}, 
      {address,          getaddr()} | Config].
@@ -524,7 +540,7 @@ ipv6(Config) when is_list(Config) ->
 	 true ->
 	     Version = ?config(http_version, Config),
 	     Host = ?config(host, Config),
-	     URI = http_request("GET /", Version, Host),
+	     URI = http_request("GET / ", Version, Host),
 	     httpd_test_lib:verify_request(?config(type, Config), Host,
  					  ?config(port, Config), [inet6], 
 					   ?config(code, Config), 
@@ -1397,7 +1413,7 @@ server_config(http, Config) ->
      {server_root, ServerRoot},
      {document_root, ?config(doc_root, Config)},
      {bind_address, any},
-     {ipfamily, inet},
+     {ipfamily, ?config(ipfamily, Config)},
      {max_header_size, 256},
      {max_header_action, close},
      {directory_index, ["index.html", "welcome.html"]},
@@ -1666,9 +1682,10 @@ cleanup_mnesia() ->
 
 transport_opts(ssl, Config) ->
     PrivDir = ?config(priv_dir, Config),
-    [{cacertfile, filename:join(PrivDir, "public_key_cacert.pem")}];
-transport_opts(_, _) ->
-    [].
+    [?config(ipfamily, Config),
+     {cacertfile, filename:join(PrivDir, "public_key_cacert.pem")}];
+transport_opts(_, Config) ->
+    [?config(ipfamily, Config)].
 
 
 %%% mod_range
diff --git a/lib/inets/test/httpd_test_lib.erl b/lib/inets/test/httpd_test_lib.erl
index 36a5bb9e71..647fa6f6c1 100644
--- a/lib/inets/test/httpd_test_lib.erl
+++ b/lib/inets/test/httpd_test_lib.erl
@@ -91,16 +91,7 @@ verify_request(SocketType, Host, Port, Node, RequestStr, Options, TimeOut)
   when (is_integer(TimeOut) orelse (TimeOut =:= infinity)) ->
     verify_request(SocketType, Host, Port, [], Node, RequestStr, Options, TimeOut).
 
-verify_request(SocketType, Host, Port, TranspOpts0, Node, RequestStr, Options, TimeOut) ->
-    %% For now, until we modernize the httpd tests 
-    TranspOpts =
-	case lists:member(inet6, TranspOpts0) of
-	    true ->
-		TranspOpts0;
-	    false ->
-		[inet | TranspOpts0]
-	end,
-    
+verify_request(SocketType, Host, Port, TranspOpts, Node, RequestStr, Options, TimeOut) ->
     try inets_test_lib:connect_bin(SocketType, Host, Port, TranspOpts) of
 	{ok, Socket} ->
 	    ok = inets_test_lib:send(SocketType, Socket, RequestStr),
-- 
cgit v1.2.3