From a13841ec7ef3365b5d263afd1c4398952a6844a1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Fri, 30 Jan 2015 11:59:54 +0100
Subject: core_lib: Deprecate functions that are no longer used by the compiler

---
 lib/compiler/src/core_lib.erl   | 50 ++++++++++-------------------------------
 lib/stdlib/src/otp_internal.erl | 13 +++++++++++
 2 files changed, 25 insertions(+), 38 deletions(-)

(limited to 'lib')

diff --git a/lib/compiler/src/core_lib.erl b/lib/compiler/src/core_lib.erl
index 730e3a5317..66319dbd36 100644
--- a/lib/compiler/src/core_lib.erl
+++ b/lib/compiler/src/core_lib.erl
@@ -20,6 +20,12 @@
 
 -module(core_lib).
 
+-deprecated({get_anno,1,next_major_release}).
+-deprecated({set_anno,2,next_major_release}).
+-deprecated({is_literal,1,next_major_release}).
+-deprecated({is_literal_list,1,next_major_release}).
+-deprecated({literal_value,1,next_major_release}).
+
 -export([get_anno/1,set_anno/2]).
 -export([is_literal/1,is_literal_list/1]).
 -export([literal_value/1]).
@@ -33,59 +39,27 @@
 %%
 -spec get_anno(cerl:cerl()) -> term().
 
-get_anno(C) -> element(2, C).
+get_anno(C) -> cerl:get_ann(C).
 
 -spec set_anno(cerl:cerl(), term()) -> cerl:cerl().
 
-set_anno(C, A) -> setelement(2, C, A).
+set_anno(C, A) -> cerl:set_ann(C, A).
 
 -spec is_literal(cerl:cerl()) -> boolean().
 
-is_literal(#c_literal{}) -> true;
-is_literal(#c_cons{hd=H,tl=T}) ->
-    is_literal(H) andalso is_literal(T);
-is_literal(#c_tuple{es=Es}) -> is_literal_list(Es);
-is_literal(#c_binary{segments=Es}) -> is_lit_bin(Es);
-is_literal(_) -> false.
+is_literal(Cerl) ->
+    cerl:is_literal(cerl:fold_literal(Cerl)).
 
 -spec is_literal_list([cerl:cerl()]) -> boolean().
 
 is_literal_list(Es) -> lists:all(fun is_literal/1, Es).
 
-is_lit_bin(Es) ->
-    lists:all(fun (#c_bitstr{val=E,size=S}) ->
-		      is_literal(E) andalso is_literal(S)
-	      end, Es).
-
 %% Return the value of LitExpr.
 -spec literal_value(cerl:c_literal() | cerl:c_binary() |
 		    cerl:c_map() | cerl:c_cons() | cerl:c_tuple()) -> term().
 
-literal_value(#c_literal{val=V}) -> V;
-literal_value(#c_binary{segments=Es}) ->
-    list_to_binary([literal_value_bin(Bit) || Bit <- Es]);
-literal_value(#c_cons{hd=H,tl=T}) ->
-    [literal_value(H)|literal_value(T)];
-literal_value(#c_tuple{es=Es}) ->
-    list_to_tuple(literal_value_list(Es));
-literal_value(#c_map{arg=Cm,es=Cmps}) ->
-    M = literal_value(Cm),
-    lists:foldl(fun(#c_map_pair{ key=Ck, val=Cv },Mi) ->
-		K = literal_value(Ck),
-		V = literal_value(Cv),
-		maps:put(K,V,Mi)
-	end, M, Cmps).
-
-literal_value_list(Vals) -> [literal_value(V) || V <- Vals].
-
-literal_value_bin(#c_bitstr{val=Val,size=Sz,unit=U,type=T,flags=Fs}) ->
-    %% We will only handle literals constructed by make_literal/1.
-    %% Could be made more general in the future if the need arises.
-    8 = literal_value(Sz),
-    1 = literal_value(U),
-    integer = literal_value(T),
-    [unsigned,big] = literal_value(Fs),
-    literal_value(Val).
+literal_value(Cerl) ->
+    cerl:concrete(cerl:fold_literal(Cerl)).
 
 %% Make a suitable values structure, expr or values, depending on Expr.
 -spec make_values([cerl:cerl()] | cerl:cerl()) -> cerl:cerl().
diff --git a/lib/stdlib/src/otp_internal.erl b/lib/stdlib/src/otp_internal.erl
index 0ace87ef5c..4a338798d0 100644
--- a/lib/stdlib/src/otp_internal.erl
+++ b/lib/stdlib/src/otp_internal.erl
@@ -578,6 +578,19 @@ obsolete_1(asn1rt, utf8_binary_to_list, 1) ->
 obsolete_1(asn1rt, utf8_list_to_binary, 1) ->
     {deprecated,{unicode,characters_to_binary,1}};
 
+%% Added in OTP 18.
+obsolete_1(core_lib, get_anno, 1) ->
+    {deprecated,{cerl,get_ann,1}};
+obsolete_1(core_lib, set_anno, 2) ->
+    {deprecated,{cerl,set_ann,2}};
+obsolete_1(core_lib, is_literal, 1) ->
+    {deprecated,{cerl,is_literal,1}};
+obsolete_1(core_lib, is_literal_list, 1) ->
+    {deprecated,"deprecated; use lists:all(fun cerl:is_literal/1, L)"
+     " instead"};
+obsolete_1(core_lib, literal_value, 1) ->
+    {deprecated,{core_lib,concrete,1}};
+
 obsolete_1(_, _, _) ->
     no.
 
-- 
cgit v1.2.3