From f02afa352f14e2dc0f3be4f6854a68b14129c2ba Mon Sep 17 00:00:00 2001
From: Hans Bolinder <hasse@erlang.org>
Date: Wed, 5 Mar 2014 10:19:01 +0100
Subject: stdlib: Fix a Dets bug with leaking file descriptors

Thanks to Hakan Mattson for reporting this bug.
---
 lib/stdlib/src/dets.erl        |  3 ++-
 lib/stdlib/test/dets_SUITE.erl | 23 ++++++++++++++++++++---
 2 files changed, 22 insertions(+), 4 deletions(-)

(limited to 'lib')

diff --git a/lib/stdlib/src/dets.erl b/lib/stdlib/src/dets.erl
index 44dad04f43..8c5c86f3b9 100644
--- a/lib/stdlib/src/dets.erl
+++ b/lib/stdlib/src/dets.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 1996-2013. All Rights Reserved.
+%% Copyright Ericsson AB 1996-2014. All Rights Reserved.
 %%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -1785,6 +1785,7 @@ read_file_header(FileName, Access, RamFile) ->
         Version =:= 9 ->
             dets_v9:read_file_header(Fd, FileName);
         true ->
+            _ = file:close(Fd),
             throw({error, {not_a_dets_file, FileName}})
     end.
 
diff --git a/lib/stdlib/test/dets_SUITE.erl b/lib/stdlib/test/dets_SUITE.erl
index 059d553b00..0f6b76a629 100644
--- a/lib/stdlib/test/dets_SUITE.erl
+++ b/lib/stdlib/test/dets_SUITE.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %% 
-%% Copyright Ericsson AB 1996-2013. All Rights Reserved.
+%% Copyright Ericsson AB 1996-2014. All Rights Reserved.
 %% 
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -52,7 +52,7 @@
          simultaneous_open/1, insert_new/1, repair_continuation/1,
          otp_5487/1, otp_6206/1, otp_6359/1, otp_4738/1, otp_7146/1,
          otp_8070/1, otp_8856/1, otp_8898/1, otp_8899/1, otp_8903/1,
-         otp_8923/1, otp_9282/1, otp_11245/1]).
+         otp_8923/1, otp_9282/1, otp_11245/1, otp_11709/1]).
 
 -export([dets_dirty_loop/0]).
 
@@ -109,7 +109,7 @@ all() ->
 	many_clients, otp_4906, otp_5402, simultaneous_open,
 	insert_new, repair_continuation, otp_5487, otp_6206,
 	otp_6359, otp_4738, otp_7146, otp_8070, otp_8856, otp_8898,
-	otp_8899, otp_8903, otp_8923, otp_9282, otp_11245
+	otp_8899, otp_8903, otp_8923, otp_9282, otp_11245, otp_11709
     ].
 
 groups() -> 
@@ -3920,6 +3920,23 @@ otp_11245(Config) when is_list(Config) ->
     file:delete(File),
     ok.
 
+otp_11709(doc) ->
+    ["OTP-11709. Bugfixes."];
+otp_11709(suite) ->
+    [];
+otp_11709(Config) when is_list(Config) ->
+    Long = <<"a sufficiently long text">>,
+
+    %% Bug: leaking file descriptor
+    P0 = pps(),
+    File = filename(otp_11709, Config),
+    ok = file:write_file(File, Long),
+    false = dets:is_dets_file(File),
+    check_pps(P0),
+
+    file:delete(File),
+    ok.
+
 %%
 %% Parts common to several test cases
 %% 
-- 
cgit v1.2.3