From 2c4e984bd1d75524fd6444dc2032f8d758a945ae Mon Sep 17 00:00:00 2001
From: Christopher Faulet <christopher@yakaz.com>
Date: Tue, 6 Sep 2011 11:10:43 +0200
Subject: Allow an infinite timeout to shutdown worker processes

Now, in child specification, the shutdown value can also be set to infinity
for worker children. This restriction was removed because this is not always
possible to predict the shutdown time for a worker. This is highly
application-dependent.
---
 system/doc/design_principles/sup_princ.xml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

(limited to 'system')

diff --git a/system/doc/design_principles/sup_princ.xml b/system/doc/design_principles/sup_princ.xml
index 2748f21bbe..42d9f3e3d8 100644
--- a/system/doc/design_principles/sup_princ.xml
+++ b/system/doc/design_principles/sup_princ.xml
@@ -181,7 +181,8 @@ init(...) ->
            terminated using <c>exit(Child, kill)</c>.</item>
           <item>If the child process is another supervisor, it should be
            set to <c>infinity</c> to give the subtree enough time to
-           shutdown.</item>
+           shutdown. It is also allowed to set it to <c>infinity</c>, if the
+           child process is a worker.</item>
         </list>
       </item>
       <item>
-- 
cgit v1.2.3


From 9679510bb27b569fd47394b6cb319916c3282de9 Mon Sep 17 00:00:00 2001
From: Christopher Faulet <christopher@yakaz.com>
Date: Wed, 14 Sep 2011 14:30:47 +0200
Subject: Add a warning to docs about workers' shutdown strategy

---
 system/doc/design_principles/sup_princ.xml | 7 +++++++
 1 file changed, 7 insertions(+)

(limited to 'system')

diff --git a/system/doc/design_principles/sup_princ.xml b/system/doc/design_principles/sup_princ.xml
index 42d9f3e3d8..9e7cc2f543 100644
--- a/system/doc/design_principles/sup_princ.xml
+++ b/system/doc/design_principles/sup_princ.xml
@@ -184,6 +184,13 @@ init(...) ->
            shutdown. It is also allowed to set it to <c>infinity</c>, if the
            child process is a worker.</item>
         </list>
+        <warning>
+          <p>Be careful by setting the <c>Shutdown</c> strategy to
+          <c>infinity</c> when the child process is a worker. Because, in this
+          situation, the termination of the supervision tree depends on the
+          child process, it must be implemented in a safe way and its cleanup
+          procedure must always return.</p>
+        </warning>
       </item>
       <item>
         <p><c>Type</c> specifies if the child process is a supervisor or
-- 
cgit v1.2.3