From 309f8bacf62efa1bcf6b85bfabc7ae45b6544b79 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lo=C3=AFc=20Hoguin?= <essen@ninenines.eu>
Date: Sat, 22 Aug 2015 14:03:50 +0200
Subject: Print a warning when discarding an option on listener startup

---
 src/ranch.erl | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

(limited to 'src/ranch.erl')

diff --git a/src/ranch.erl b/src/ranch.erl
index 9f764d3..769447a 100644
--- a/src/ranch.erl
+++ b/src/ranch.erl
@@ -134,8 +134,11 @@ filter_options(UserOptions, AllowedKeys, DefaultOptions) ->
 %% 2-tuple options.
 filter_user_options([Opt = {Key, _}|Tail], AllowedKeys) ->
 	case lists:member(Key, AllowedKeys) of
-		true -> [Opt|filter_user_options(Tail, AllowedKeys)];
-		false -> filter_user_options(Tail, AllowedKeys)
+		true ->
+			[Opt|filter_user_options(Tail, AllowedKeys)];
+		false ->
+			filter_options_warning(Opt),
+			filter_user_options(Tail, AllowedKeys)
 	end;
 %% Special option forms.
 filter_user_options([inet|Tail], AllowedKeys) ->
@@ -143,15 +146,16 @@ filter_user_options([inet|Tail], AllowedKeys) ->
 filter_user_options([inet6|Tail], AllowedKeys) ->
 	[inet6|filter_user_options(Tail, AllowedKeys)];
 filter_user_options([Opt = {raw, _, _, _}|Tail], AllowedKeys) ->
-	case lists:member(raw, AllowedKeys) of
-		true -> [Opt|filter_user_options(Tail, AllowedKeys)];
-		false -> filter_user_options(Tail, AllowedKeys)
-	end;
-filter_user_options([_|Tail], AllowedKeys) ->
+	[Opt|filter_user_options(Tail, AllowedKeys)];
+filter_user_options([Opt|Tail], AllowedKeys) ->
+	filter_options_warning(Opt),
 	filter_user_options(Tail, AllowedKeys);
 filter_user_options([], _) ->
 	[].
 
+filter_options_warning(Opt) ->
+	error_logger:warning_msg("Transport option ~p unknown or invalid.~n", [Opt]).
+
 merge_options({Key, _} = Option, OptionList) ->
 	lists:keystore(Key, 1, OptionList, Option);
 merge_options(Option, OptionList) ->
-- 
cgit v1.2.3