From a843394883ee215dc97b26dddae588b6a3308950 Mon Sep 17 00:00:00 2001 From: Tristan Sloughter Date: Thu, 19 Nov 2015 09:47:35 -0600 Subject: update neotoma plugin --- rebar.config | 5 +---- src/rlx_goal.erl | 10 +++++----- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/rebar.config b/rebar.config index 647efa8..747f415 100644 --- a/rebar.config +++ b/rebar.config @@ -24,10 +24,7 @@ %% Profiles ==================================================================== -{profiles, [{dev, [{deps, [{neotoma, ".*", - {git, "https://github.com/seancribbs/neotoma.git", {branch, "master"}}} - ]} - ]}, +{profiles, [{dev, [{plugins, [rebar3_neotoma_plugin]}]}, {test, [{erl_opts, [debug_info]}]} ]}. diff --git a/src/rlx_goal.erl b/src/rlx_goal.erl index e588a0e..354aa48 100644 --- a/src/rlx_goal.erl +++ b/src/rlx_goal.erl @@ -16,9 +16,9 @@ file(Filename) -> case file:read_file(Filename) of {ok,Bin} -> parse(Bin); Err -> Err end. -spec parse(binary() | list()) -> any(). -parse(List) when is_list(List) -> parse(list_to_binary(List)); +parse(List) when is_list(List) -> parse(unicode:characters_to_binary(List)); parse(Input) when is_binary(Input) -> - setup_memo(), + _ = setup_memo(), Result = case 'constraint'(Input,{{line,1},{column,1}}) of {AST, <<>>, _Index} -> AST; Any -> Any @@ -115,7 +115,7 @@ setup_memo() -> release_memo() -> ets:delete(memo_table_name()). --spec memoize(index(), atom(), term()) -> true. +-spec memoize(index(), atom(), parse_result()) -> true. memoize(Index, Name, Result) -> Memo = case ets:lookup(memo_table_name(), Index) of [] -> []; @@ -252,8 +252,8 @@ p_label(Tag, P) -> -endif. -ifdef(p_scan). --spec p_scan(parse_fun(), input(), index(), [term()]) -> parse_result(). -p_scan(_, [], Index, Accum) -> {lists:reverse( Accum ), [], Index}; +-spec p_scan(parse_fun(), input(), index(), [term()]) -> {[term()], input(), index()}. +p_scan(_, <<>>, Index, Accum) -> {lists:reverse(Accum), <<>>, Index}; p_scan(P, Inp, Index, Accum) -> case P(Inp, Index) of {fail,_} -> {lists:reverse(Accum), Inp, Index}; -- cgit v1.2.3 From d6f42edec9bfa0bc9bda3834059888a2a8b03024 Mon Sep 17 00:00:00 2001 From: Tristan Sloughter Date: Thu, 19 Nov 2015 09:48:09 -0600 Subject: make remote shell a hidden node so they don't try to join each other --- priv/templates/extended_bin | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/priv/templates/extended_bin b/priv/templates/extended_bin index 0046502..eaeb54a 100755 --- a/priv/templates/extended_bin +++ b/priv/templates/extended_bin @@ -59,7 +59,7 @@ relx_rem_sh() { # Setup remote shell command to control node exec "$BINDIR/erl" "$NAME_TYPE" "$id" -remsh "$NAME" -boot start_clean \ -boot_var ERTS_LIB_DIR "$ERTS_LIB_DIR" \ - -setcookie "$COOKIE" -kernel net_ticktime $TICKTIME + -setcookie "$COOKIE" -hidden -kernel net_ticktime $TICKTIME } # Generate a random id -- cgit v1.2.3 From 811bb9a36e27dcdc72d7f7cfea85e726f7e16ab9 Mon Sep 17 00:00:00 2001 From: Tristan Sloughter Date: Thu, 19 Nov 2015 10:23:20 -0600 Subject: relup successfully created message should be an info log not an error --- src/rlx_prv_relup.erl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/rlx_prv_relup.erl b/src/rlx_prv_relup.erl index 0dbe8f9..ad30914 100644 --- a/src/rlx_prv_relup.erl +++ b/src/rlx_prv_relup.erl @@ -133,14 +133,14 @@ make_upfrom_script(State, Release, UpFrom) -> systools:make_relup(CurrentRel, [UpFromRel], [UpFromRel], CorrectOptions) end) of ok -> - ec_cmd_log:error(rlx_state:log(State), + ec_cmd_log:info(rlx_state:log(State), "relup from ~s to ~s successfully created!", [UpFromRel, CurrentRel]), {ok, State}; error -> ?RLX_ERROR({relup_script_generation_error, CurrentRel, UpFromRel}); {ok, RelUp, _, []} -> - ec_cmd_log:error(rlx_state:log(State), + ec_cmd_log:info(rlx_state:log(State), "relup successfully created!"), write_relup_file(State, Release, RelUp), {ok, State}; -- cgit v1.2.3 From 8ae76495300474eaa87c22bcc254cf35245a9177 Mon Sep 17 00:00:00 2001 From: Tristan Sloughter Date: Thu, 19 Nov 2015 10:29:23 -0600 Subject: move relup successfuly created log message to after it is sucessfully written --- src/rlx_prv_relup.erl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/rlx_prv_relup.erl b/src/rlx_prv_relup.erl index ad30914..9ac2135 100644 --- a/src/rlx_prv_relup.erl +++ b/src/rlx_prv_relup.erl @@ -140,9 +140,9 @@ make_upfrom_script(State, Release, UpFrom) -> error -> ?RLX_ERROR({relup_script_generation_error, CurrentRel, UpFromRel}); {ok, RelUp, _, []} -> - ec_cmd_log:info(rlx_state:log(State), - "relup successfully created!"), write_relup_file(State, Release, RelUp), + ec_cmd_log:info(rlx_state:log(State), + "relup successfully created!"), {ok, State}; {ok,_, Module,Warnings} -> ?RLX_ERROR({relup_script_generation_warn, Module, Warnings}); -- cgit v1.2.3