From 01504d1fb05430bc0fe5f2b30ebd57747a080d84 Mon Sep 17 00:00:00 2001 From: Tristan Sloughter Date: Fri, 13 Sep 2013 13:55:14 -0500 Subject: replace use of wildcard ** since it is not in {erts, ErtsDir}, {outdir, OutputDir}]) of ok -> - TempDir = filename:join(OutputDir, integer_to_list(erlang:phash2(make_ref()))), + TempDir = ec_file:insecure_mkdtemp(), try update_tar(State, TempDir, OutputDir, Name, Vsn, ErtsVersion) catch E:R -> - file:del_dir(TempDir), + ec_file:remove(TempDir, [recursive]), ?RLX_ERROR({tar_generation_error, E, R}) end; {ok, Module, Warnings} -> @@ -484,7 +484,7 @@ update_tar(State, TempDir, OutputDir, Name, Vsn, ErtsVersion) -> {"bin", filename:join([OutputDir, "bin"])}], [compressed]), rlx_log:info(rlx_state:log(State), "tarball ~s successfully created!~n", [TarFile]), - rlx_util:delete_dir(TempDir), + ec_file:remove(TempDir, [recursive]), {ok, State}. make_upfrom_script(State, Release, UpFrom) -> diff --git a/src/rlx_util.erl b/src/rlx_util.erl index c821896..ac6af5c 100644 --- a/src/rlx_util.erl +++ b/src/rlx_util.erl @@ -21,8 +21,7 @@ %%% @doc Trivial utility file to help handle common tasks -module(rlx_util). --export([delete_dir/1, - mkdir_p/1, +-export([mkdir_p/1, to_binary/1, to_string/1, to_atom/1, @@ -40,19 +39,6 @@ %%============================================================================ %% API %%============================================================================ -%% @doc Deletes non-empty directory -delete_dir(Path) -> - lists:foldr(fun(File, ok) -> - case filelib:is_dir(File) of - true -> - file:del_dir(File); - false -> - file:delete(File) - end - end, ok, filelib:wildcard(filename:join(Path, "**"))), - ok = file:del_dir(Path). - - %% @doc Makes a directory including parent dirs if they are missing. -spec mkdir_p(string()) -> ok | {error, Reason::file:posix()}. mkdir_p(Path) -> -- cgit v1.2.3