aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBjörn Gustavsson <[email protected]>2014-02-24 16:44:09 +0100
committerBjörn Gustavsson <[email protected]>2014-02-24 16:44:09 +0100
commitda723e829683bfb1f7bd98dfa6c1231a0854df25 (patch)
tree8e5a83b9822d61c088d0c0350f1e8b6a2cff6e5d
parent4ce83eb728748787f8a2da6155112c6da42a0eba (diff)
downloadotp-da723e829683bfb1f7bd98dfa6c1231a0854df25.tar.gz
otp-da723e829683bfb1f7bd98dfa6c1231a0854df25.tar.bz2
otp-da723e829683bfb1f7bd98dfa6c1231a0854df25.zip
gs: Eliminate a compiler warning
We don't want to introduce a potential incompatibility in a deprecated application, so we will fix the warning by removing the dead code that causes the warning.
-rw-r--r--lib/gs/src/gstk_generic.erl10
1 files changed, 5 insertions, 5 deletions
diff --git a/lib/gs/src/gstk_generic.erl b/lib/gs/src/gstk_generic.erl
index 9b0efd07c1..573b4e05bb 100644
--- a/lib/gs/src/gstk_generic.erl
+++ b/lib/gs/src/gstk_generic.erl
@@ -323,11 +323,11 @@ handle_external_opt_call([Opt|Options],Gstkid,TkW,DB,ExtraArg,ExtRes,S,P,C) ->
end.
handle_external_read(Res) ->
- _ = case Res of
- {bad_result,{Objtype,Reason,Option}} ->
- {error,{Objtype,Reason,Option}};
- _ -> ok
- end,
+ %% We have removed dead code here that attempted to translate
+ %% a bad return value from {bad_result,{A,B,C}} to {error,{A,B,C}}.
+ %% Since the gs application is deprecated, we don't want to introduce
+ %% a potential incompatibility; thus we have removed the dead code
+ %% instead of correcting it.
Res.
%%----------------------------------------------------------------------