diff options
| author | Loïc Hoguin <[email protected]> | 2017-10-31 17:15:11 +0000 |
|---|---|---|
| committer | Loïc Hoguin <[email protected]> | 2017-10-31 17:15:11 +0000 |
| commit | ad9ab51648d16181960f4a4eeb27ea6948d35739 (patch) | |
| tree | 97b4e0afc94ff6d26e6051fb00893e61e05f24bb | |
| parent | 4e85ad76a0ce2584175d4aabbd3e9900bd405056 (diff) | |
| download | cowboy-ad9ab51648d16181960f4a4eeb27ea6948d35739.tar.gz cowboy-ad9ab51648d16181960f4a4eeb27ea6948d35739.tar.bz2 cowboy-ad9ab51648d16181960f4a4eeb27ea6948d35739.zip | |
Add some todos
| -rw-r--r-- | src/cowboy_http2.erl | 1 | ||||
| -rw-r--r-- | src/cowboy_stream_h.erl | 1 | ||||
| -rw-r--r-- | src/cowboy_websocket.erl | 1 | ||||
| -rw-r--r-- | test/static_handler_SUITE.erl | 4 |
4 files changed, 6 insertions, 1 deletions
diff --git a/src/cowboy_http2.erl b/src/cowboy_http2.erl index 663d33a..21f0aeb 100644 --- a/src/cowboy_http2.erl +++ b/src/cowboy_http2.erl @@ -774,6 +774,7 @@ stream_req_init(State=#state{ref=Ref, peer=Peer, sock=Sock, cert=Cert}, _ -> undefined end, + %% @todo If this fails to parse we want to gracefully handle the crash. {Host, Port} = cow_http_hd:parse_host(Authority), {Path, Qs} = cow_http:parse_fullpath(PathWithQs), Req = #{ diff --git a/src/cowboy_stream_h.erl b/src/cowboy_stream_h.erl index 8cd1457..8cbdbb0 100644 --- a/src/cowboy_stream_h.erl +++ b/src/cowboy_stream_h.erl @@ -232,6 +232,7 @@ request_process(Req, Env, Middlewares) -> _:Reason when OTP =:= "19" -> Stacktrace = erlang:get_stacktrace(), erlang:raise(exit, {Reason, Stacktrace}, Stacktrace); + %% @todo I don't think this clause is necessary. Class:Reason -> erlang:raise(Class, Reason, erlang:get_stacktrace()) end. diff --git a/src/cowboy_websocket.erl b/src/cowboy_websocket.erl index 549ef0d..3ec9f9a 100644 --- a/src/cowboy_websocket.erl +++ b/src/cowboy_websocket.erl @@ -172,6 +172,7 @@ websocket_handshake(State=#state{key=Key}, Req=#{pid := Pid, streamid := StreamID}, HandlerState, Env) -> Challenge = base64:encode(crypto:hash(sha, << Key/binary, "258EAFA5-E914-47DA-95CA-C5AB0DC85B11" >>)), + %% @todo We don't want date and server headers. Headers = cowboy_req:response_headers(#{ <<"connection">> => <<"Upgrade">>, <<"upgrade">> => <<"websocket">>, diff --git a/test/static_handler_SUITE.erl b/test/static_handler_SUITE.erl index 726d035..e4e0ef1 100644 --- a/test/static_handler_SUITE.erl +++ b/test/static_handler_SUITE.erl @@ -354,7 +354,9 @@ dir_error_directory_slash(Config) -> dir_error_doesnt_exist(Config) -> doc("Try to get a file that does not exist."), - {404, _, _} = do_get(config(prefix, Config) ++ "/not.found", Config), + %% @todo Check that the content-type header is removed. + {404, _Headers, _} = do_get(config(prefix, Config) ++ "/not.found", Config), +% false = lists:keyfind(<<"content-type">>, 1, Headers), ok. dir_error_dot(Config) -> |