aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLoïc Hoguin <[email protected]>2011-12-22 20:42:18 +0100
committerLoïc Hoguin <[email protected]>2011-12-22 21:00:09 +0100
commiteea6b2ab803cec304e55069d9e79b54615b69b07 (patch)
tree5b8f5e2cc4d78de912baaa78a75160c99f17a78e
parent7a68a38e5a0bc5bea4b542aebf123d8c3496dee0 (diff)
downloadcowboy-eea6b2ab803cec304e55069d9e79b54615b69b07.tar.gz
cowboy-eea6b2ab803cec304e55069d9e79b54615b69b07.tar.bz2
cowboy-eea6b2ab803cec304e55069d9e79b54615b69b07.zip
Websocket control frames payload length must be lower than 126 bytes
-rw-r--r--src/cowboy_http_websocket.erl48
1 files changed, 32 insertions, 16 deletions
diff --git a/src/cowboy_http_websocket.erl b/src/cowboy_http_websocket.erl
index dd1550e..08804b1 100644
--- a/src/cowboy_http_websocket.erl
+++ b/src/cowboy_http_websocket.erl
@@ -269,27 +269,43 @@ websocket_data(State=#state{version=Version}, Req, HandlerState, Data)
websocket_data(State=#state{version=Version}, Req, HandlerState, Data)
when Version =/= 0 ->
<< 1:1, 0:3, Opcode:4, Mask:1, PayloadLen:7, Rest/bits >> = Data,
- {PayloadLen2, Rest2} = case {PayloadLen, Rest} of
- {126, << L:16, R/bits >>} -> {L, R};
- {126, Rest} -> {undefined, Rest};
- {127, << 0:1, L:63, R/bits >>} -> {L, R};
- {127, Rest} -> {undefined, Rest};
- {PayloadLen, Rest} -> {PayloadLen, Rest}
- end,
- case {Mask, PayloadLen2} of
+ case {PayloadLen, Rest} of
+ {126, _} when Opcode >= 8 -> websocket_close(
+ State, Req, HandlerState, {error, protocol});
+ {127, _} when Opcode >= 8 -> websocket_close(
+ State, Req, HandlerState, {error, protocol});
+ {126, << L:16, R/bits >>} -> websocket_before_unmask(
+ State, Req, HandlerState, Data, R, Opcode, Mask, L);
+ {126, Rest} -> websocket_before_unmask(
+ State, Req, HandlerState, Data, Rest, Opcode, Mask, undefined);
+ {127, << 0:1, L:63, R/bits >>} -> websocket_before_unmask(
+ State, Req, HandlerState, Data, R, Opcode, Mask, L);
+ {127, Rest} -> websocket_before_unmask(
+ State, Req, HandlerState, Data, Rest, Opcode, Mask, undefined);
+ {PayloadLen, Rest} -> websocket_before_unmask(
+ State, Req, HandlerState, Data, Rest, Opcode, Mask, PayloadLen)
+ end;
+%% Something was wrong with the frame. Close the connection.
+websocket_data(State, Req, HandlerState, _Bad) ->
+ websocket_close(State, Req, HandlerState, {error, badframe}).
+
+%% hybi routing depending on whether unmasking is needed.
+-spec websocket_before_unmask(#state{}, #http_req{}, any(), binary(),
+ binary(), opcode(), 0 | 1, non_neg_integer() | undefined)
+ -> closed | none().
+websocket_before_unmask(State, Req, HandlerState, Data,
+ Rest, Opcode, Mask, PayloadLen) ->
+ case {Mask, PayloadLen} of
{0, 0} ->
- websocket_dispatch(State, Req, HandlerState, Rest2, Opcode, <<>>);
- {1, N} when N + 4 > byte_size(Rest2); N =:= undefined ->
+ websocket_dispatch(State, Req, HandlerState, Rest, Opcode, <<>>);
+ {1, N} when N + 4 > byte_size(Rest); N =:= undefined ->
%% @todo We probably should allow limiting frame length.
handler_before_loop(State, Req, HandlerState, Data);
{1, _N} ->
- << MaskKey:32, Payload:PayloadLen2/binary, Rest3/bits >> = Rest2,
- websocket_unmask(State, Req, HandlerState, Rest3,
+ << MaskKey:32, Payload:PayloadLen/binary, Rest2/bits >> = Rest,
+ websocket_unmask(State, Req, HandlerState, Rest2,
Opcode, Payload, MaskKey)
- end;
-%% Something was wrong with the frame. Close the connection.
-websocket_data(State, Req, HandlerState, _Bad) ->
- websocket_close(State, Req, HandlerState, {error, badframe}).
+ end.
%% hybi unmasking.
-spec websocket_unmask(#state{}, #http_req{}, any(), binary(),