aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLoïc Hoguin <[email protected]>2017-09-05 13:25:06 +0200
committerLoïc Hoguin <[email protected]>2017-09-05 13:25:06 +0200
commit2376983295569e897c82f2b4a63d1485beae7263 (patch)
tree8723461161ab6cdea7d8cc8c9761db706dbccf78
parentd1c210b1052ac38a74c7d6554b5f700f28195080 (diff)
downloadcowboy-2376983295569e897c82f2b4a63d1485beae7263.tar.gz
cowboy-2376983295569e897c82f2b4a63d1485beae7263.tar.bz2
cowboy-2376983295569e897c82f2b4a63d1485beae7263.zip
Remove transfer-encoding parsing from cowboy_req
The header never reaches this point.
-rw-r--r--doc/src/manual/cowboy_req.parse_header.asciidoc2
-rw-r--r--src/cowboy_req.erl4
2 files changed, 0 insertions, 6 deletions
diff --git a/doc/src/manual/cowboy_req.parse_header.asciidoc b/doc/src/manual/cowboy_req.parse_header.asciidoc
index 6980e14..3f68179 100644
--- a/doc/src/manual/cowboy_req.parse_header.asciidoc
+++ b/doc/src/manual/cowboy_req.parse_header.asciidoc
@@ -162,8 +162,6 @@ To :: non_neg_integer() | infinity
Final :: neg_integer()
----
-// @todo Remove transfer-encoding from the headers parsed by this function.
-
.sec-websocket-extensions
[source,erlang]
----
diff --git a/src/cowboy_req.erl b/src/cowboy_req.erl
index 3b2ecc8..0106771 100644
--- a/src/cowboy_req.erl
+++ b/src/cowboy_req.erl
@@ -356,9 +356,6 @@ parse_header(Name = <<"content-length">>, Req) ->
parse_header(Name, Req, 0, fun cow_http_hd:parse_content_length/1);
parse_header(Name = <<"cookie">>, Req) ->
parse_header(Name, Req, [], fun cow_cookie:parse_cookie/1);
-%% @todo That header is abstracted out and should never reach cowboy_req.
-parse_header(Name = <<"transfer-encoding">>, Req) ->
- parse_header(Name, Req, [<<"identity">>], fun cow_http_hd:parse_transfer_encoding/1);
parse_header(Name, Req) ->
parse_header(Name, Req, undefined).
@@ -383,7 +380,6 @@ parse_header_fun(<<"if-unmodified-since">>) -> fun cow_http_hd:parse_if_unmodifi
parse_header_fun(<<"range">>) -> fun cow_http_hd:parse_range/1;
parse_header_fun(<<"sec-websocket-extensions">>) -> fun cow_http_hd:parse_sec_websocket_extensions/1;
parse_header_fun(<<"sec-websocket-protocol">>) -> fun cow_http_hd:parse_sec_websocket_protocol_req/1;
-parse_header_fun(<<"transfer-encoding">>) -> fun cow_http_hd:parse_transfer_encoding/1;
parse_header_fun(<<"upgrade">>) -> fun cow_http_hd:parse_upgrade/1;
parse_header_fun(<<"x-forwarded-for">>) -> fun cow_http_hd:parse_x_forwarded_for/1.