aboutsummaryrefslogtreecommitdiffstats
path: root/src/cowboy_protocol.erl
diff options
context:
space:
mode:
authorLoïc Hoguin <[email protected]>2012-09-15 22:19:39 +0200
committerLoïc Hoguin <[email protected]>2012-09-15 22:19:39 +0200
commit0aaa717575dd4a9287a473381d90b7cef15cda95 (patch)
tree31df63155e8acf5f39828b32cf240d89cb3750ee /src/cowboy_protocol.erl
parent27d591180ca3dd8b0d3c63c1293da5a3c4f4321f (diff)
downloadcowboy-0aaa717575dd4a9287a473381d90b7cef15cda95.tar.gz
cowboy-0aaa717575dd4a9287a473381d90b7cef15cda95.tar.bz2
cowboy-0aaa717575dd4a9287a473381d90b7cef15cda95.zip
Remove duplicate code for ensure_response
Diffstat (limited to 'src/cowboy_protocol.erl')
-rw-r--r--src/cowboy_protocol.erl25
1 files changed, 3 insertions, 22 deletions
diff --git a/src/cowboy_protocol.erl b/src/cowboy_protocol.erl
index bc56e76..bb94a40 100644
--- a/src/cowboy_protocol.erl
+++ b/src/cowboy_protocol.erl
@@ -403,12 +403,12 @@ terminate_request(HandlerState, Req, State) ->
-spec next_request(cowboy_req:req(), #state{}, any()) -> ok.
next_request(Req=#http_req{connection=Conn}, State=#state{
req_keepalive=Keepalive}, HandlerRes) ->
- RespRes = ensure_response(Req),
+ cowboy_req:ensure_response(Req, 204),
{BodyRes, Buffer} = ensure_body_processed(Req),
%% Flush the resp_sent message before moving on.
receive {cowboy_req, resp_sent} -> ok after 0 -> ok end,
- case {HandlerRes, BodyRes, RespRes, Conn} of
- {ok, ok, ok, keepalive} ->
+ case {HandlerRes, BodyRes, Conn} of
+ {ok, ok, keepalive} ->
?MODULE:parse_request(State#state{
buffer=Buffer, host_tokens=undefined, path_tokens=undefined,
req_empty_lines=0, req_keepalive=Keepalive + 1});
@@ -428,25 +428,6 @@ ensure_body_processed(Req=#http_req{body_state={stream, _, _, _}}) ->
{ok, Req2} = cowboy_req:multipart_skip(Req),
ensure_body_processed(Req2).
--spec ensure_response(cowboy_req:req()) -> ok.
-%% The handler has already fully replied to the client.
-ensure_response(#http_req{resp_state=done}) ->
- ok;
-%% No response has been sent but everything apparently went fine.
-%% Reply with 204 No Content to indicate this.
-ensure_response(Req=#http_req{resp_state=waiting}) ->
- _ = cowboy_req:reply(204, [], [], Req),
- ok;
-%% Terminate the chunked body for HTTP/1.1 only.
-ensure_response(#http_req{method='HEAD', resp_state=chunks}) ->
- ok;
-ensure_response(#http_req{version={1, 0}, resp_state=chunks}) ->
- ok;
-ensure_response(#http_req{socket=Socket, transport=Transport,
- resp_state=chunks}) ->
- Transport:send(Socket, <<"0\r\n\r\n">>),
- ok.
-
%% Only send an error reply if there is no resp_sent message.
-spec error_terminate(cowboy_http:status(), #state{}) -> ok.
error_terminate(Code, State=#state{socket=Socket, transport=Transport,