aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorLoïc Hoguin <[email protected]>2013-01-18 18:18:29 +0100
committerLoïc Hoguin <[email protected]>2013-01-18 18:21:28 +0100
commit09c68ca755d685183c10d1a406844603e7bcf43b (patch)
tree7af40d24e542db1b87a58bce6ddd26eebfdf92d8 /src
parentacd6847d3df2d0bca923918bdc5040e9b68c9b3f (diff)
downloadcowboy-09c68ca755d685183c10d1a406844603e7bcf43b.tar.gz
cowboy-09c68ca755d685183c10d1a406844603e7bcf43b.tar.bz2
cowboy-09c68ca755d685183c10d1a406844603e7bcf43b.zip
Remove a few old @todo comments
Diffstat (limited to 'src')
-rw-r--r--src/cowboy_req.erl2
-rw-r--r--src/cowboy_rest.erl6
2 files changed, 0 insertions, 8 deletions
diff --git a/src/cowboy_req.erl b/src/cowboy_req.erl
index 89758dd..4782eed 100644
--- a/src/cowboy_req.erl
+++ b/src/cowboy_req.erl
@@ -728,7 +728,6 @@ skip_body(Req) ->
%% @doc Return the full body sent with the request, parsed as an
%% application/x-www-form-urlencoded string. Essentially a POST query string.
-%% @todo We need an option to limit the size of the body for QS too.
-spec body_qs(Req)
-> {ok, [{binary(), binary() | true}], Req} | {error, atom()}
when Req::req().
@@ -765,7 +764,6 @@ multipart_data(Req=#http_req{multipart={Length, Cont}}) ->
multipart_data(Req=#http_req{body_state=done}) ->
{eof, Req}.
-%% @todo Typespecs.
multipart_data(Req, Length, {headers, Headers, Cont}) ->
{headers, Headers, Req#http_req{multipart={Length, Cont}}};
multipart_data(Req, Length, {body, Data, Cont}) ->
diff --git a/src/cowboy_rest.erl b/src/cowboy_rest.erl
index 963b2f7..f5bc22d 100644
--- a/src/cowboy_rest.erl
+++ b/src/cowboy_rest.erl
@@ -846,12 +846,6 @@ generate_etag(Req, State=#state{etag=undefined}) ->
case call(Req, State, generate_etag) of
no_call ->
{undefined, Req, State#state{etag=no_call}};
- %% Previously the return value from the generate_etag/2 callback was set
- %% as the value of the ETag header in the response. Therefore the only
- %% valid return type was `binary()'. If a handler returns a `binary()'
- %% it must be mapped to the expected type or it'll always fail to
- %% compare equal to any entity tags present in the request headers.
- %% @todo Remove support for binary return values after 0.6.
{Etag, Req2, HandlerState} when is_binary(Etag) ->
[Etag2] = cowboy_http:entity_tag_match(Etag),
{Etag2, Req2, State#state{handler_state=HandlerState, etag=Etag2}};