diff options
author | Loïc Hoguin <[email protected]> | 2014-09-30 20:12:13 +0300 |
---|---|---|
committer | Loïc Hoguin <[email protected]> | 2014-09-30 20:12:13 +0300 |
commit | 0dc063ab7d94edb37c61f821b5d8e4c2da7f8ff1 (patch) | |
tree | aaa71b552b0348fc403cc68ba8318e58f213d4fd /test/http_SUITE.erl | |
parent | 5ce4c2bfb40ecc4b687a2941e612025a1c4ff913 (diff) | |
download | cowboy-0dc063ab7d94edb37c61f821b5d8e4c2da7f8ff1.tar.gz cowboy-0dc063ab7d94edb37c61f821b5d8e4c2da7f8ff1.tar.bz2 cowboy-0dc063ab7d94edb37c61f821b5d8e4c2da7f8ff1.zip |
Improve handler interface and documentation
This change simplifies a little more the sub protocols mechanism.
Aliases have been removed. The renaming of loop handlers as long
polling handlers has been reverted.
Plain HTTP handlers now simply do their work in the init/2
callback. There is no specific code for them.
Loop handlers now follow the same return value as Websocket,
they use ok to continue and shutdown to stop.
Terminate reasons for all handler types have been documented.
The terminate callback is now appropriately called in all cases
(or should be).
Behaviors for all handler types have been moved in the module
that implement them. This means that cowboy_handler replaces
the cowboy_http_handler behavior, and similarly cowboy_loop
replaces cowboy_loop_handler, cowboy_websocket replaces
cowboy_websocket_handler. Finally cowboy_rest now has the
start of a behavior in it and will have the full list of
optional callbacks defined once Erlang 18.0 gets released.
The guide has been reorganized and should be easier to follow.
Diffstat (limited to 'test/http_SUITE.erl')
-rw-r--r-- | test/http_SUITE.erl | 33 |
1 files changed, 1 insertions, 32 deletions
diff --git a/test/http_SUITE.erl b/test/http_SUITE.erl index e98ce1b..3783b6e 100644 --- a/test/http_SUITE.erl +++ b/test/http_SUITE.erl @@ -142,7 +142,6 @@ init_dispatch(Config) -> {"localhost", [ {"/chunked_response", http_chunked, []}, {"/streamed_response", http_streamed, []}, - {"/init_shutdown", http_init_shutdown, []}, {"/headers/dupe", http_handler, [{headers, [{<<"connection">>, <<"close">>}]}]}, {"/set_resp/header", http_set_resp, @@ -292,9 +291,7 @@ check_status(Config) -> {403, "/static/unreadable"}, {404, "/not/found"}, {404, "/static/not_found"}, - {500, "/handler_errors?case=handle_before_reply"}, - {500, "/handler_errors?case=init_before_reply"}, - {666, "/init_shutdown"} + {500, "/handler_errors?case=init_before_reply"} ], _ = [{Status, URL} = begin Ret = do_get(URL, Config), @@ -342,40 +339,12 @@ echo_body_qs_max_length(Config) -> {response, nofin, 413, _} = gun:await(ConnPid, Ref), ok. -error_chain_handle_after_reply(Config) -> - {ConnPid, MRef} = gun_monitor_open(Config), - Ref1 = gun:get(ConnPid, "/"), - Ref2 = gun:get(ConnPid, "/handler_errors?case=handle_after_reply"), - {response, nofin, 200, _} = gun:await(ConnPid, Ref1, MRef), - {response, nofin, 200, _} = gun:await(ConnPid, Ref2, MRef), - gun_is_gone(ConnPid, MRef). - -error_chain_handle_before_reply(Config) -> - {ConnPid, MRef} = gun_monitor_open(Config), - Ref1 = gun:get(ConnPid, "/"), - Ref2 = gun:get(ConnPid, "/handler_errors?case=handle_before_reply"), - {response, nofin, 200, _} = gun:await(ConnPid, Ref1, MRef), - {response, fin, 500, _} = gun:await(ConnPid, Ref2, MRef), - gun_is_gone(ConnPid, MRef). - -error_handle_after_reply(Config) -> - {ConnPid, MRef} = gun_monitor_open(Config), - Ref = gun:get(ConnPid, "/handler_errors?case=handle_after_reply"), - {response, nofin, 200, _} = gun:await(ConnPid, Ref, MRef), - gun_is_gone(ConnPid, MRef). - error_init_after_reply(Config) -> {ConnPid, MRef} = gun_monitor_open(Config), Ref = gun:get(ConnPid, "/handler_errors?case=init_after_reply"), {response, nofin, 200, _} = gun:await(ConnPid, Ref, MRef), gun_is_gone(ConnPid, MRef). -error_init_reply_handle_error(Config) -> - {ConnPid, MRef} = gun_monitor_open(Config), - Ref = gun:get(ConnPid, "/handler_errors?case=init_reply_handle_error"), - {response, nofin, 200, _} = gun:await(ConnPid, Ref, MRef), - gun_is_gone(ConnPid, MRef). - headers_dupe(Config) -> {ConnPid, MRef} = gun_monitor_open(Config), Ref = gun:get(ConnPid, "/headers/dupe"), |