aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)Author
2019-10-06Fix PUT when resource doesn't exist in flowchartLoïc Hoguin
This required moving around a lot of things so hopefully I did not add errors while doing so. Only time will tell. Also add the 415 that can result from content_types_accepted.
2019-10-06Document how to recover from cookie parsing errorsLoïc Hoguin
2019-10-05Add Websocket option validate_utf8Loïc Hoguin
This allows disabling the UTF-8 validation check for text and close frames.
2019-10-05Don't discard data following a Websocket upgrade requestLoïc Hoguin
While the protocol does not allow sending data before receiving a successful Websocket upgrade response, we do not want to discard that data if it does come in.
2019-10-05Fix REST flowchart around 201 response for PUTLoïc Hoguin
When the method is PUT we do not check the location header.
2019-10-05Add cowboy_req:filter_cookies/2Loïc Hoguin
2019-10-04Make cowboy_compress_h add vary: accept-encodingLoïc Hoguin
2019-10-04Improve some early_error testsLoïc Hoguin
2019-10-03Document media type wildcard in content_types_acceptedLoïc Hoguin
2019-10-03Make stream_error early_error reasons consistentLoïc Hoguin
Now both HTTP/1.1 and HTTP/2 follow the documented format. HTTP/1.1 was including an extra element containing the StreamID before, which was unnecessary because it is also given as argument to the callback. HTTP/2 early_error will now include headers in its PartialReq.
2019-10-03Add HTTP/2 tests with responses with HTTP/1.1 specific headersLoïc Hoguin
2019-10-03Document stopping the listener in App:stop/1Loïc Hoguin
2019-10-02Fix another Dialyzer warningLoïc Hoguin
2019-10-02Ensure we can stream the response body from any processLoïc Hoguin
2019-10-02Ensure we can read the request body from any processLoïc Hoguin
2019-10-02Make sure cowboy_http doesn't receive stray timeout messagesLoïc Hoguin
2019-10-02Add {set_options, #{metrics_user_data := Map}}Loïc Hoguin
This allows giving custom metadata to the metrics stream handler. This can be useful to for example provide the name of the module handling the request which is only known after routing. But any user data is allowed. When called multiple times the user data maps are merged.
2019-10-02Add more HTTP/1.1 header parsing testsLoïc Hoguin
Fix a case where Cowboy was waiting for more data that simply did not come. Now Cowboy will generate an error immediately when a header line has no colon separator. These test cases come from known request smuggling attack vectors. Cowboy was not vulnerable to any of them.
2019-10-02Fix a Dialyzer warning and improve some typesLoïc Hoguin
2019-10-02Fix HTTP/2 CVEsLoïc Hoguin
A number of HTTP/2 CVEs were documented recently: https://www.kb.cert.org/vuls/id/605641/ This commit, along with a few changes and additions in Cowlib, fix or improve protection against all of them. For CVE-2019-9511, also known as Data Dribble, the new option stream_window_data_threshold can be used to control how little the DATA frames that Cowboy sends can get. For CVE-2019-9516, also known as 0-Length Headers Leak, Cowboy will now simply reject streams containing 0-length header names. For CVE-2019-9517, also known as Internal Data Buffering, the backpressure changes were already pretty good at preventing this issue, but a new option max_connection_buffer_size was added for even better control over how much memory we are willing to allocate. For CVE-2019-9512, also known as Ping Flood; CVE-2019-9515, also known as Settings Flood; CVE-2019-9518, also known as Empty Frame Flooding; and similar undocumented scenarios, a frame rate limiting mechanism was added. By default Cowboy will now allow 1000 frames every 10 seconds. This can be configured via max_received_frame_rate. For CVE-2019-9514, also known as Reset Flood, another rate limiting mechanism was added and can be configured via max_reset_stream_rate. By default Cowboy will do up to 10 stream resets every 10 seconds. Finally, nothing was done for CVE-2019-9513, also known as Resource Loop, because Cowboy does not currently implement the HTTP/2 priority mechanism (in parts because these issues were well known from the start). Tests were added for all cases except Internal Data Buffering, which I'm not sure how to test, and Resource Loop, which is not currently relevant.
2019-10-02Update gun_down messages in test suitesLoïc Hoguin
2019-10-02Remove lingering_data tuple handlingLoïc Hoguin
2019-09-28Add persistent_term support to the routerLoïc Hoguin
2019-09-18Only test on the latest release per OTP major version by defaultLoïc Hoguin
2019-09-16Fix closing of connection on response_body_too_smallLoïc Hoguin
2019-09-15Split up urlencoded tests to speed up req_SUITELoïc Hoguin
2019-09-15Skip req_SUITE:read_body_mtu on WindowsLoïc Hoguin
On Windows the loopback MTU seems to be set to 0xFFFFFFFF (basically no limit) which makes the test irrelevant.
2019-09-15Increase the period for req_SUITE:read_body_periodLoïc Hoguin
This should increase the likelihood of the test succeeding on slower systems when run over TLS.
2019-09-15Fix h2spec_SUITE init_per_suite return valuesLoïc Hoguin
2019-09-15Fix intermittent failures in sys_SUITELoïc Hoguin
2019-09-14Implement backpressure on cowboy_req:stream_bodyLoïc Hoguin
This should limit the amount of memory that Cowboy is using when a handler is sending data much faster than the network. The new max_stream_buffer_size is a soft limit and only has an effect when the cowboy_stream_h handler is used.
2019-09-07Improve the cowboy_static consistency across platformsLoïc Hoguin
As a result we explictly reject path_info components that include a forward slash, backward slash or NUL character. This only applies to the [...] part of the path for dir/priv_dir configuration. Also improve the tests so that they work on Windows.
2019-09-06Fix tests failing following Gun update to masterLoïc Hoguin
2019-09-06Rename Gun's transport_opts to tls_optsLoïc Hoguin
2019-09-06Correct tests modifying mtime of static filesLoïc Hoguin
On macOS this resulted in failure because the mtime did not change between test groups. The mtime should now always change.
2019-09-06Use Gun master for testsLoïc Hoguin
We no longer support OTP-19 so we don't need to stay on the old Gun version anymore.
2019-09-06Fix using custom fields in ReqLoïc Hoguin
2019-09-06Document unit for options that are in bytesLoïc Hoguin
2019-09-05rest_pastebin example: Add a constraint for lang parameterLoïc Hoguin
2019-09-05file_server example: Fix ../ linksruanpienaar
Amended to fix an issue with repeated path segments.
2019-09-05Minor grammar correctionAlastair Hole
Noun 'setup' -> verb phrase 'set up'
2019-09-05Fix and optimize sending of WINDOW_UPDATE framesLoïc Hoguin
For long-running connections it was possible for the connection window to become larger than allowed by the protocol because the window increases claimed by stream handlers were never reclaimed even if no data was consumed. The new code applies heuristics to fix this and reduce the number of WINDOW_UPDATE frames that are sent. It includes six new options to control that behavior: margin, max and threshold for both the connection and stream windows. The margin is some extra space added on top of the requested read size. The max is the maximum window size at any given time. The threshold is a minimum window size that must be reached before we even consider sending more WINDOW_UPDATE frames. We also avoid sending WINDOW_UPDATE frames when there is already enough space in the window, or when the read size is 0. Cowlib is set to master until a new tag is done.
2019-08-29Update CI to only test on OTP-20+Loïc Hoguin
2019-08-16Gracefully shut down HTTP/2 connections on GOAWAYLoïc Hoguin
2019-07-26Add a zero-length DATA frame in the lingering_data testTony Han
2019-07-22Add more related specsLoïc Hoguin
2019-07-16Make Cowboy compatible with upcoming Ranch 2.0juhlig
2019-07-16Data received after RST_STREAM counts toward windowTony Han
2019-07-12Add two related specsLoïc Hoguin
2019-05-27Add two new RFCs to the listLoïc Hoguin